Repository navigation
[TASK] Add support for TYPO3 v14 - #11
Merged
Merged
Conversation
chriwo
force-pushed
the
task/support-typo3v14
branch
from
September 21, 2026 16:15
796a029 to
707bc9e
Compare
chriwo
force-pushed
the
task/support-typo3v14
branch
from
September 21, 2026 16:25
707bc9e to
b043c33
Compare
chriwo
marked this pull request as ready for review
September 21, 2026 16:27
s12r
reviewed
Sep 22, 2026
| ->withSets([ | ||
| PHPUnitSetList::ANNOTATIONS_TO_ATTRIBUTES, | ||
| LevelSetList::UP_TO_PHP_85, | ||
| LevelSetList::UP_TO_PHP_82, |
Contributor
There was a problem hiding this comment.
Is this a downgrade from PHP 8.5 to PHP 8.2?
Contributor
Author
There was a problem hiding this comment.
This is only a downgrade for the used rector rules not for the extension itself. The extension is intended to support PHP 8.2 until 8.5 . If we set the LevelSetList::UP_TO_PHP_85, rector should adapt the codebase for PHP 8.5, although support for older versions is not guaranteed.
This is because Rector can only convert the PHP code for a single version, not for a range of versions.
s12r
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.