Remove unused login prop #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused registerCTA prop from the sqm-portal-login component and adds story files for the Google login form component to improve documentation and testing capabilities.
Changes:
- Removed unused
registerCTAprop fromsqm-portal-logincomponent - Added Google login form stories to the stencilbook
- Enhanced error handling in the Google login demo hook
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/mint-components/src/components/sqm-stencilbook/sqm-stencilbook.tsx | Imports and registers the new Google login form stories |
| packages/mint-components/src/components/sqm-portal-login/sqm-portal-login.tsx | Removes the unused registerCTA prop |
| packages/mint-components/src/components/sqm-portal-google-registration-form/PortalGoogleRegistrationForm.stories.tsx | Updates Default story to use the actual component instead of the view |
| packages/mint-components/src/components/sqm-portal-google-login/sqm-portal-google-login.tsx | Allows error state to be overridden via demoData |
| packages/mint-components/src/components/sqm-portal-google-login/GoogleLoginForm.stories.tsx | Creates new story file with Default, WithError, and Loading stories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Links
Checklists
Development
Paperwork
Code review