Fix valgrind

[pinkenburg]

Types of changes

• [ X] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

This should fix the valgrind errors from the CaloFitting test

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

This PR addresses valgrind failures in the CaloFitting test by tightening memory cleanup in a couple of reconstruction components. Please use best judgment when reviewing this summary, as AI-generated summaries can make mistakes.

Motivation / context

• Fix leaks and stale ROOT fitter state reported by valgrind in calorimeter-related tests.
• Improve destructor cleanup for objects created during run initialization.

Key changes

• CaloTowerBuilder:
  • Deletes cdbttree_sepd_map in the destructor to release the SEPD-specific CDB tree allocated during InitRun.
  • Minor include reordering only; no functional change.
• MbdSig:
  • Adds ROOT header dependencies needed for fitter-related cleanup.
  • Resets the global ROOT fitter cache with TVirtualFitter::SetFitter(nullptr, 0) in the destructor before deleting member objects.
• MbdSig.h:
  • Reworks ROOT type usage with forward declarations and header cleanup to reduce coupling.

Potential risk areas

• ROOT/global state cleanup may affect shared fitter behavior if other code assumes the cached fitter persists.
• Destructor changes could subtly alter reconstruction lifecycle behavior or memory ownership assumptions.
• Header dependency changes should be checked for build consistency and any downstream compile impacts.
• No IO format changes are expected, but reconstruction outputs should still be validated.

Possible future improvements

• Audit similar reconstruction classes for missing destructor cleanup and global ROOT state handling.
• Add targeted regression tests or valgrind-focused checks for these components.
• Review ownership patterns around CDB trees and fitter objects to make cleanup more explicit.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: de253145-c5bd-4809-b4d5-6174789c45f8

📥 Commits

Reviewing files that changed from the base of the PR and between c89585e and dcde384.

📒 Files selected for processing (3)

• offline/packages/CaloReco/CaloTowerBuilder.cc
• offline/packages/mbd/MbdSig.cc
• offline/packages/mbd/MbdSig.h

---

📝 Walkthrough

Walkthrough

The PR reorders includes in two modules, adds deletion of a calibration mapping tree in one destructor, and updates another module’s ROOT declarations plus destructor to reset ROOT’s cached fitter before member deletion.

Changes

CaloTowerBuilder changes

Layer / File(s)	Summary
Include order and tree deletion offline/packages/CaloReco/CaloTowerBuilder.cc	The include block is reordered, and the destructor deletes cdbttree_sepd_map with the existing members.

MbdSig ROOT declarations and fitter reset

Layer / File(s)	Summary
ROOT declarations offline/packages/mbd/MbdSig.h	The header adds <Rtypes.h> and <limits> and replaces the direct TH1.h include with ROOT forward declarations.
Source includes and fitter reset offline/packages/mbd/MbdSig.cc	The source include block adds TH1.h and TVirtualFitter.h, and the destructor calls TVirtualFitter::SetFitter(nullptr, 0) before deleting members.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sphenix-jenkins-ci]

Build & test report

Report for commit dcde38478d4bf977cd43cea963b961e5dcb28396:

• builds and tests overall are SUCCESS.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, 📊 trends
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.7331 / 72, and combined p-Value = 0.99837
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
  • Tracking QA with Distortions: build is SUCCESS, 📊 trends
    • 📊 QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = 0.00500048 / 56, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = 6.66098e-05 / 50, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
    • 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
    • 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
    • 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
    • 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2_Fitting.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration