Updated soft-deprecated SwiftUI APIs and added Sendable to CGFrame - #5
Merged
Merged
Conversation
Changed .overlay(_:) and .mask(_:) to their trailing-closure forms and .accessibility(hidden:) to .accessibilityHidden(_:). All replacements are available at the package's minimum deployment targets. The overlay change also guards against the SDK 27 @ContentBuilder unification, which removes the View constraint from result builders and makes the direct-argument form of overlay ambiguous for ShapeStyle expressions carrying .opacity() or .blendMode(). The trailing-closure form is Apple's documented fix.
CGFrame conforms to CGFrameRepresentable, which is a plain protocol, so it got no Sendable conformance despite being composed entirely of Sendable parts. Public types do not get one implicitly. The shape types do not need this. SwiftUI declares Shape as refining Sendable, so CornerCustom, RelativeCornerCustom, CornerRectangle, CornerTriangle, CornerPentagon, SketchyLine and SketchyLines already conform transitively through Shape and InsettableShape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed .overlay(:) and .mask(:) to their trailing-closure forms and
.accessibility(hidden:) to .accessibilityHidden(_:).
Added Sendable conformance to CGFrame