arm64: fix multiple shell spawning by resetting idle thread context #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run_userspace_from_ext2 transitions to userspace, timer interrupts may have already saved thread 0's (idle) context with ELR pointing to kernel_main. Later, when thread 0 is scheduled, it would resume kernel_main instead of going to the idle loop, causing multiple init_shell processes to spawn. Fix by explicitly resetting thread 0's context to point to idle_loop_arm64 after spawn_as_current() but before transitioning to userspace. This ensures thread 0 always goes to the idle loop. Also adds TODO comment for ARM64 render queue implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When
run_userspace_from_ext2transitions to userspace, timer interrupts may have already saved thread 0's (idle) context with ELR pointing tokernel_main. Later, when thread 0 is scheduled, it would resumekernel_maininstead of going to the idle loop, causing multiple init_shell processes to spawn repeatedly.Fix
After calling
spawn_as_current()but before transitioning to userspace, explicitly reset thread 0's saved context to point toidle_loop_arm64. This ensures thread 0 always goes to the idle loop when scheduled.Test plan
🤖 Generated with Claude Code