Liquid Today: remount the illness banner, the auto-workout prompt, and the hydration value

[vishk23]

Liquid is the default Today on both platforms, so anything mounted only in classic TodayView is effectively unmounted. Three things were in that state. This restores them at the same positions classic and Android use.

I found these auditing NOOP for things it computes or captures that never reach a user, checking each against a real device DB rather than the schema. Same class as #105 (workout-in-progress card) and the #992 / B1 / #543 restorations already in LiquidTodayView.

Defaults, for reference: StrandiOS/App/RootTabView.swift:46 and Strand/App/RootView.swift:201 both default liquidTodayEnabled = true.

1. HealthAlertBanner — a raised health warning had no home-screen surface

Mounted at TodayView.swift:1270 (iOS) and :1272 (macOS), never in Liquid. Android pins it on Today too (TodayScreen.kt:1306).

While unmounted, a .raised illness/strain alert survived only as one push at the moment it fired (IllnessNotifier.post) and as HeadsUpCard two taps deep in More → Health. The push is transient and the Health route is not somewhere you land by accident, so in practice the warning was invisible.

Pinned above the reorderable block, matching classic, so it can't be dragged below the fold. Renders nothing when model.healthAlert is nil.

2. AutoWorkoutCard — a Settings toggle with no visible effect

AutoWorkoutCard() had exactly one instantiation repo-wide, TodayView.swift:1352. So on the default screen PuffinExperiment.autoDetectWorkoutsKey (SettingsView.swift:122) did nothing observable: switch auto-detect on, never get shown a suggestion. Android keeps the card (TodayScreen.kt:1554).

Restored to the same slot classic uses (after the cards block, before Data Sources). Self-gates on the toggle and on the detector actually finding an unsaved, un-dismissed window, so it renders nothing by default.

3. Hydration card value was the literal "–"

LiquidTodayView.swift:698-699 hardcoded value: "–". HydrationGoal.cardValueString is unit-tested and byte-identical to the Android twin (String.format(Locale.US, "%.1f / %.1f L")), but classic TodayView.swift:2237 was its only caller — so a logged drink never appeared on the default screen.

Now reads the same total + goal and shows the goal fraction on the ring. repo.hydrationSeq joins the .task id, the same trigger set reloadHydration() uses, so logging a drink refreshes immediately.

Also adds the enablement filter Liquid never had. Classic filters via enabledDashboardCards (TodayView.swift:235-241) and Android via it != HYDRATION || hydrationEnabled; Liquid's ForEach(DashboardCardPrefs.decodeEnabled(...)) filtered on neither, so anyone who added the card and later switched the feature off kept a permanently-blank row.

Verification

xcodebuild -project Strand.xcodeproj -scheme Strand -destination 'platform=macOS' -configuration Debug build → BUILD SUCCEEDED, both on this branch and on my fork's main.

All three are self-contained views or existing store reads — no new types, no migration, no protocol change. HealthAlertBanner and AutoWorkoutCard take their dependencies from the environment, so the mounts are bare.

Not included, but found in the same pass

Still classic-only, listed so it's on the record rather than as scope creep — happy to send follow-ups:

• Updates inbox + unread bell. UpdatesInboxView is instantiated at exactly one site repo-wide (TodayView.swift:1432). seedWhatsNewIfNeeded() (StrandiOSApp.swift:339) still writes a "What's new in NOOP x.y.z" item into UpdateStore on every release, and "N new days of history landed" is still posted (TodayView.swift:4106-4112). On the default screen nothing reads that store, so every release note is written and discarded.
• Charge breakdown sheet. Liquid's Charge cell opens the generic ScoringGuideView (LiquidTodayView.swift:539) rather than chargeBreakdownSheet (TodayView.swift:1441), so the per-driver breakdown of the user's own Charge — and the Readiness read S4 deliberately folded behind that tap (TodayView.swift:1342-1345) — has no door on the home screen.
• First-run "Live now. Your scores are building." note (TodayView.swift:1291-1294), including the actionable "import your WHOOP export and it backfills in about a minute". Android keeps it (TodayScreen.kt:1281-1287). This is the worst moment to lose an explanation, since every tile is blank.
• FullDayChartView.swift:66, @State private var reloadTick = 0 — its own comment says it is "bumped on every settled zoom/metric change so the re-read task re-runs at the new resolution". Nothing bumps it and nothing observes it, so zooming the full-day chart never re-reads at finer resolution. HydrationView.swift:25/73/364 implements the same idiom correctly, so it looks like a copy that was left unwired.
• WeeklyDigestCard / WeeklyDigestView (WeeklyDigestView.swift:65, :84) have zero call sites repo-wide, and no .digest sidebar case exists. The engine itself is fine — WeeklyDigestContent ships inside Trends (TrendsView.swift:353) and Android has its own card. It's the two wrappers plus three translated strings that only they reference.

[ryanbr]

Reviewed. All three are real — a Settings toggle with no observable effect and a raised health warning with no home-screen surface are the kind of thing that only ever gets found by someone checking against a device DB rather than the schema. Thanks also for compiling it; that is more than CI does for this file, since app-build.yml is disabled and nothing else touches app-target Swift.

Verified rather than assumed, given nothing here type-checks in CI:

• HydrationGoal.cardValueString(totalML:goalML:) and fraction(totalML:goalML:) exist with exactly those signatures; HealthAlertBanner / AutoWorkoutCard are bare no-arg views; profile is an @EnvironmentObject already on this view.
• The enablement filter matches classic's enabledDashboardCards and Android's it != HYDRATION || hydrationEnabled.
• Both "not included" findings I spot-checked hold: FullDayChartView.swift:66 reloadTick is declared and never bumped or observed, and UpdatesInboxView( has exactly one call site repo-wide, in classic TodayView.

One bonus you get for free: repo.hydrationTotal now returns hand-logged plus water imported from Apple Health / Health Connect (#974, merged earlier today), so the Liquid card picks that up with no extra work.

One change I would rework before landing

.task(id: "\(repo.refreshSeq)-\(selectedDayOffset)-\(repo.hydrationSeq)-\(hydrationEnabled)") { await load() }

This wires hydration into the heavy loader. load() has 13 awaits and does the repo.days scan (up to 599 rows) that the function's own comment calls out as "the stutter" it was restructured to avoid. So tapping Sip / Cup / Bottle now re-runs the entire home-screen load per tap.

Classic deliberately does the opposite, and says so at TodayView.swift:1360:

#989: … re-read just the two hydration fields. Cheap (one metricSeries row), **never re-runs the heavy loads.**

The PR comment says it uses "the same trigger set classic reloadHydration() uses" — the triggers match, but they are attached to a different handler. Mirroring classic keeps the main task untouched and adds:

.task(id: repo.hydrationSeq) { await reloadHydration() }
.onChangeCompat(of: hydrationEnabled) { _ in Task { await reloadHydration() } }

with the two reads you already wrote lifted out of load() into reloadHydration(). onChangeCompat is the same helper classic uses, so nothing new is needed.

Worth knowing for scale: until earlier today hydrationSeq was bumped on every Apple Health sync, i.e. on each of six hourly observer wakes — so as written this would also have fired a full load() in the background all day. #986 narrowed the bump to real changes, so that half is already gone. The drink-log path is the part still worth fixing.

Everything else looks right to me, and the two mounts are exactly the leaves classic and Android use. Happy to re-review once the trigger is split.

[ryanbr]

Merged — thanks, all three were real and exactly the kind of thing only a device-DB audit surfaces.

On the "not included" list, two notes so the follow-ups land clean:

The first-run "Live now. Your scores are building." note is the one worth doing next — greenlit. Losing it on the default screen at first run is the worst case (every tile is blank and there's no explanation, plus the actionable "import your WHOOP export and it backfills in about a minute"). Android keeps it, so it's a straight Liquid restoration in the same vein as this PR. Happy to review it as a standalone.

One correction on the FullDayChartView.reloadTick item — it isn't actually a bug. Zoom does re-read at the new resolution: taskKey (FullDayChartView.swift:118-121) keys on visibleWindow's bounds (lo/hi), and visibleWindow = zoomDomain ?? dayBounds, so a settled zoom changes zoomDomain → visibleWindow → taskKey → .task(id: taskKey) re-runs reload(). reloadTick is just vestigial @State (declared at :66, never bumped, never observed) left over from an earlier approach that the taskKey path superseded — its comment is stale. So there's nothing to wire up; at most it's a dead-state deletion + comment fix, not a behavior fix. Didn't want you to spend time "restoring" a path that already works.

The Updates inbox and Charge-breakdown-sheet items are real but lower priority — send them whenever; no rush.