Repository navigation
Conversation
…d runs; route numeric sheets to charts - DECK-1: npm is the package manager (bun.lockb removed, lockfile regenerated, test tools moved to devDependencies); use-toast is .tsx; vitest uses the SWC plugin; broken tests repaired; Supabase types gain user_projects; conditional hooks in useToast fixed; lint has 0 errors; CI added - DECK-2: SheetJS 0.20.3 from the SheetJS CDN (outside both advisory ranges); 20 MB file cap, 50 sheets, 1M declared cells per sheet checked before expansion - DECK-3: every exit path ends with END_PROCESSING; cancellation reports CANCELLED instead of a validation error; only the newest run settles state - DECK-4: chart eligibility is checked before the table fallback - Remove Math.random processing-time stat; add user_projects migration with RLS - Tests: 18 unit tests, browser check for upload to a valid PPTX download Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011GFY8v4QeVYzawpSLcJCzz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes audit findings DECK-1 to DECK-4.
DECK-1: fresh clone now installs, builds, type-checks, lints and tests
bun.lockbis removed andpackage-lock.jsonregenerated, sonpm cisucceeds. Test tools (vitest,jsdom, Testing Library) moved to devDependencies, and the missing@testing-library/jest-domwas added.use-toast.tsis renamed to.tsx, since it contains JSX.vitest.config.tsnow uses@vitejs/plugin-react-swc, the plugin the manifest actually installs.useToastcalled hooks conditionally (a rules-of-hooks error). The hooks now run unconditionally, andtoast()no longer throws before a provider mounts.src/integrations/supabase/types.tsdescribed a different project's tables (qr_codes,webhooks, …).user_projectsis added, which removes all 16 type errors indataService.ts.event.target, and they expected a progress bar without a selected file). Both are fixed.no-explicit-anyand fast-refresh notices;no-explicit-anyis set to warn.npm ci, type check, lint, tests, build.DECK-2: workbook parser
xlsx0.18.5 is replaced by SheetJS 0.20.3 fromcdn.sheetjs.com, outside both the prototype-pollution and ReDoS advisory ranges. SheetJS no longer publishes to npm.!refbefore the sheet is expanded, so a small file that declares a huge range is rejected. The UI copy now says 20 MB.DECK-3: failed or cancelled runs no longer stay busy
END_PROCESSINGtransition runs infinallyon every exit path. Failures and cancellations clearisProcessingwithout marking the session completed.CANCELLEDrather than a validation or extraction error.DECK-4: numeric sheets become charts
isChartable: a header row, 2+ data rows, and a numeric value column) now runs before the table fallback. Text-only sheets remain tables. The policy is documented in the code and the README.Math.random()"processing time" stat is removed; it now returnsnulluntil real durations are recorded.Database:
supabase/migrations/…_user_projects.sqldefines the table the app expects, with owner-only RLS policies. I could not see the deployed database, so compare before applying.Verification
chart), 4 terminal-state cases, and the parser's version and cell-limit checks.dev/check-upload-download.cjs(Playwright, with Supabase auth stubbed) uploads a 3-quarter workbook and downloads the deck. The.pptxopens as a valid zip with 5 slides and 3 charts, and there are no page errors.npm cipasses type check, lint, tests and build.Still open (separate PR):
npm auditdrops from 32 entries to 19. The 7 runtime ones need major upgrades: react-router 7, zod 4, and image-size ≥ 2.0.3, which pptxgenjs 4.0.1 pins to 1.x. The rest are dev tooling: vitest 4 for the critical tinypool entry, and esbuild through vite. No licence is added.Generated by Claude Code