Repository navigation
ci: Log in to Docker Hub before building - #17
Merged
Merged
Conversation
The base image was pulled anonymously from the runner's shared IP, which can hit Docker Hub's anonymous pull limit and fail builds with 429. Log in before the build whenever secrets are available (everything except pull requests from forks). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QTN7At86i5TYDmozENSNv8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build jobs pulled the
postgresbase image from Docker Hub anonymously, from the shared IPs of GitHub's runners. That counts against Docker Hub's anonymous pull limit, so builds could start failing with429 Too Many Requestseven when the code is fine.The previous Dockerfile avoided this by pulling from
mirror.gcr.io. The refactor in #16 dropped that.The build job now logs in to Docker Hub before building, so pulls count against the account. The separate login before pushing is gone, because it's no longer needed.
Pull requests from forks get no secrets, so they skip the login and build anonymously, same as before.
Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01QTN7At86i5TYDmozENSNv8