Add rate limiting to protect CPU-intensive ML endpoints#103
Open
midaa1 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Right now, the API has no rate limiting at all. This means anyone can send hundreds of requests in a short time, which
is a problem because our ML endpoints (calibration and prediction) use a lot of CPU. Without any protection, the
server can easily get overloaded or even crash if someone sends too many requests on purpose or by accident.
This PR adds rate limiting using flask-limiter so each IP address can only make a certain number of requests per
minute.
What did I change?
app/main.py
models and uses the most CPU.
needs protection.
without getting blocked.
requirements.txt
tests/test_rate_limiting.py
tests/conftest.py
false failures.
Important note
Right now the rate limiter uses in-memory storage, which works fine for a single server. If we deploy with multiple
workers or multiple instances later, we will need to switch to Redis storage so the limits are shared across all
instances.
How to test
checking that you get a 429 response