Conversation
Treat the missing projects.assign_session sibling as a supported fallback, create the gateway session in the Project cwd using the real stock session.create request shape, and retain the returned runtime mapping. Add widget and wire-contract regressions. Co-authored-by: Thaeland <Jon.Beets@paceremail.com>
rusty4444
force-pushed
the
fix/project-chat-stock-gateway
branch
from
September 15, 2026 21:11
2be221e to
8b0d4c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #100 with the stock Hermes gateway contract.
Project chats currently require
projects.assign_session, but stock Hermes does not ship that sibling RPC. The app therefore blocks the chat before it can open. The existing PR #101 identifies the right cwd-based fallback, but itssession.createrequest still includes the unsupportedsession_idfield and also contains an unrelated feature commit.Changes
projects.assign_sessionsibling as a non-fatal compatibility fallbackcwdand no client-suppliedsession_id, matching stock HermesSessionCreateParamsA future gateway that implements
projects.assign_sessionstill uses the explicit assignment path. The cwd fallback is only used when that method is absent.Verification
flutter analyze --no-pub: no issuesflutter test --no-pub: 949 passedgit diff --checkThis is a clean, single-scope alternative to #101. The original cwd fallback was proposed by @Thaeland and is credited in the commit.