Skip to content

Update demo example with latest changes#30

Merged
cecton merged 4 commits intorustminded:mainfrom
cecton:fix-demo-example
Feb 11, 2025
Merged

Update demo example with latest changes#30
cecton merged 4 commits intorustminded:mainfrom
cecton:fix-demo-example

Conversation

@cecton
Copy link
Member

@cecton cecton commented Feb 10, 2025

@yozhgoor The previous release will need to be yanked because there is no way for the user of this lib to remove that default_value. It will force a cargo check on everybody it's unusable.

Related to #28

@cecton cecton self-assigned this Feb 10, 2025
@cecton cecton requested a review from yozhgoor February 10, 2025 22:23
@cecton cecton marked this pull request as ready for review February 10, 2025 22:23
This reverts commit 92a34db.

The cache wasn't useful anyway.
Copy link
Member

@yozhgoor yozhgoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cecton cecton merged commit a495e86 into rustminded:main Feb 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants