Conversation
"PKCS" is a specific name for a sequence of standards from RSA corporation. eg, Ed25519 is not one of those, and neither is anything related to ECDSA, so "PKCS_ED25519" is a bit of a misnomer.
ctz
changed the title
SignatureAlgorithm values a bitSignatureAlgorithm values a bit
ctz
added
the
next-major-release
djc
approved these changes
Feb 27, 2026
est31
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed some of these bits, not fixing a specific issue.
I also noticed that there's a lot of RSA-PSS-related things that are commented out. I've left that alone but it probably deserves some attention for someone who knows the background?