Conversation
There was a problem hiding this comment.
Looks good overall, just some pedantism. For the linking-to-issue/PR questions, maybe we link both the original report and the fix/impl PR, but that might be a lot of work, so maybe just link the fix PR?
@rustbot author
| - Add new nightly-only `float_literal_trailing_zero` option [#3187](https://github.com/rust-lang/rustfmt/issues/3187) | ||
| - See the [`float_literal_trailing_zero` configuration documentation](https://rust-lang.github.io/rustfmt/?version=v1.9.0&search=#float_literal_trailing_zero) for more details |
There was a problem hiding this comment.
Question: should these point to the original feature request issue and/or the impl? In this particular case we point to the issue, the impl is #5834
CHANGELOG.md
Outdated
| - Correct version chunk splitting in the internal version sort algorithm [#6407](https://github.com/rust-lang/rustfmt/pull/6407) | ||
| - Extend support for single line let-chain formatting to include cases where the left hand side operand is a literal, in alignment with finalized style rules as part of let-chain stabilization [#6492](https://github.com/rust-lang/rustfmt/pull/6492) | ||
| - Begin initial formatting for `use closures` and `use chains` (`#![feature(ergonomic_clones)]`). Previously, the closure and chain was left as the developer wrote it [#6532](https://github.com/rust-lang/rustfmt/pull/6532) | ||
| - The unstable `required_version` configuration option now support semantic versioning [#6063](https://github.com/rust-lang/rustfmt/issues/6063) |
There was a problem hiding this comment.
Question: should this link to the impl PR #6066 instead?
| - Fix panic when sorting imports [#6333](https://github.com/rust-lang/rustfmt/issues/6333) | ||
| - Fix issue with `wrap_comments` invalidating code blocks [#6417](https://github.com/rust-lang/rustfmt/pull/6417) | ||
| - No longer remove closure block label within a macro call [#6465](https://github.com/rust-lang/rustfmt/issues/6465) | ||
| - Fix idempotency issue when normalizing imports [#6558](https://github.com/rust-lang/rustfmt/issues/6558) |
| - Fix issue with `wrap_comments` invalidating code blocks [#6417](https://github.com/rust-lang/rustfmt/pull/6417) | ||
| - No longer remove closure block label within a macro call [#6465](https://github.com/rust-lang/rustfmt/issues/6465) | ||
| - Fix idempotency issue when normalizing imports [#6558](https://github.com/rust-lang/rustfmt/issues/6558) | ||
| - Properly split long pattern in `if-let` at the `max_width` when setting `style_edition=2027` [#6202](https://github.com/rust-lang/rustfmt/issues/6202) |
CHANGELOG.md
Outdated
| - Extend support for single line let-chain formatting to include cases where the left hand side operand is a literal, in alignment with finalized style rules as part of let-chain stabilization [#6492](https://github.com/rust-lang/rustfmt/pull/6492) | ||
| - Begin initial formatting for `use closures` and `use chains` (`#![feature(ergonomic_clones)]`). Previously, the closure and chain was left as the developer wrote it [#6532](https://github.com/rust-lang/rustfmt/pull/6532) | ||
| - The unstable `required_version` configuration option now support semantic versioning [#6063](https://github.com/rust-lang/rustfmt/issues/6063) | ||
| - Format `lazy_static::lazy_static!` like `lazy_static!` when setting `style_edition=2027` [#6287](https://github.com/rust-lang/rustfmt/issues/6287) |
| - No longer remove closure block label within a macro call [#6465](https://github.com/rust-lang/rustfmt/issues/6465) | ||
| - Fix idempotency issue when normalizing imports [#6558](https://github.com/rust-lang/rustfmt/issues/6558) | ||
| - Properly split long pattern in `if-let` at the `max_width` when setting `style_edition=2027` [#6202](https://github.com/rust-lang/rustfmt/issues/6202) | ||
| - Prevent panic when rewriting missing spans that contain unicode whitespace chars [#5739](https://github.com/rust-lang/rustfmt/issues/5739) |
| - Properly split long pattern in `if-let` at the `max_width` when setting `style_edition=2027` [#6202](https://github.com/rust-lang/rustfmt/issues/6202) | ||
| - Prevent panic when rewriting missing spans that contain unicode whitespace chars [#5739](https://github.com/rust-lang/rustfmt/issues/5739) | ||
| - Allow `NotADirectory` errors when looking up rustfmt configuration files [#6624](https://github.com/rust-lang/rustfmt/pull/6624) | ||
| - Prevent panic when sorting imports starting with a `_` for `style_edition=2015|2018|2021` [#6668](https://github.com/rust-lang/rustfmt/issues/6668) |
| - Prevent panic when rewriting missing spans that contain unicode whitespace chars [#5739](https://github.com/rust-lang/rustfmt/issues/5739) | ||
| - Allow `NotADirectory` errors when looking up rustfmt configuration files [#6624](https://github.com/rust-lang/rustfmt/pull/6624) | ||
| - Prevent panic when sorting imports starting with a `_` for `style_edition=2015|2018|2021` [#6668](https://github.com/rust-lang/rustfmt/issues/6668) | ||
| - Properly wrap long `impl trait` function parameters at the `max_width` when setting `style_edition=2027` [#6381](https://github.com/rust-lang/rustfmt/issues/6381) |
| - Begin initial formatting for `use closures` and `use chains` (`#![feature(ergonomic_clones)]`). Previously, the closure and chain was left as the developer wrote it [#6532](https://github.com/rust-lang/rustfmt/pull/6532) | ||
| - The unstable `required_version` configuration option now support semantic versioning [#6063](https://github.com/rust-lang/rustfmt/issues/6063) | ||
| - Format `lazy_static::lazy_static!` like `lazy_static!` when setting `style_edition=2027` [#6287](https://github.com/rust-lang/rustfmt/issues/6287) | ||
| - Top-level imports are no longer merged when setting `imports_granularity=Module`. Note that `imports_granularity=Module` is still an unstable configuration [#6191](https://github.com/rust-lang/rustfmt/issues/6191) |
|
Reminder, once the PR becomes ready for a review, use |
…chars in missing spans
…ition=2015|2018|2021
315a622 to
24e6691
Compare
|
@jieyouxu thanks for pointing out that I missed documenting those two changes. From what I can tell by looking at the CHANGELOG is that we've linked to both |
Looking at all the PRs with the
release-noteslabel, these seemed to me like all the outstanding entries that needed to be mentioned.r? @jieyouxu