Closed
Conversation
These are necessary for running the rustc test suite with cg_clif
Remove duplicated implementations of borrowed locals analysis
…an-DPC Fix some test annotations These are necessary for running the rustc test suite with cg_clif.
Clarify `#[derive(PartialEq)]` on enums Fixes rust-lang#97945
…gnostic-in-rustc-expand, r=Dylan-DPC Use `create_snapshot_for_diagnostic` instead of `clone` for `Parser` Use [`create_snapshot_for_diagnostic`](https://github.com/rust-lang/rust/blob/cd119057160cedea245aa2679add56723f3dc784/compiler/rustc_parse/src/parser/diagnostics.rs#L214-L223) I implemented in rust-lang#94731 instead of `clone` to avoid duplicate unclosed delims errors being emitted when the `Parser` is dropped. I missed this one in rust-lang#95068.
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
|
📌 Commit 9764452 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 9764452 with merge 673fd5791fbf50c699478757a535a36b8da47b70... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[derive(PartialEq)]on enums #97950 (Clarify#[derive(PartialEq)]on enums)create_snapshot_for_diagnosticinstead ofcloneforParser#98020 (Usecreate_snapshot_for_diagnosticinstead ofcloneforParser)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup