Suggest adding { .. } around a const function call with arguments#94731
Merged
bors merged 8 commits intorust-lang:masterfrom Mar 18, 2022
Merged
Suggest adding { .. } around a const function call with arguments#94731bors merged 8 commits intorust-lang:masterfrom
{ .. } around a const function call with arguments#94731bors merged 8 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
Contributor
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
davidtwco
requested changes
Mar 8, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
Improvement looks good, some minor comments and the CI failure to fix.
This comment has been minimized.
This comment has been minimized.
davidtwco
added
S-waiting-on-author
TaKO8Ki
force-pushed
the
const-generic-expr-recovery
branch
from
7dffd49 to
527b1f3
Compare
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
davidtwco
requested changes
Mar 9, 2022
TaKO8Ki
force-pushed
the
const-generic-expr-recovery
branch
from
6e1378a to
192acb4
Compare
davidtwco
reviewed
Mar 9, 2022
TaKO8Ki
force-pushed
the
const-generic-expr-recovery
branch
from
9483b54 to
3ded252
Compare
davidtwco
requested changes
Mar 10, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
This looks good, thanks for making these changes, I've left a few more comments.
Member
Author
|
r? @rust-lang/compiler |
Contributor
|
@bors r=davidtwco,oli-obk |
Collaborator
|
📌 Commit 9a65322 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2022
Rollup of 10 pull requests Successful merges: - rust-lang#91133 (Improve `unsafe` diagnostic) - rust-lang#93222 (Make ErrorReported impossible to construct outside `rustc_errors`) - rust-lang#93745 (Stabilize ADX target feature) - rust-lang#94309 ([generator_interior] Be more precise with scopes of borrowed places) - rust-lang#94698 (Remove redundant code from copy-suggestions) - rust-lang#94731 (Suggest adding `{ .. }` around a const function call with arguments) - rust-lang#94960 (Fix many spelling mistakes) - rust-lang#94982 (Add deprecated_safe feature gate and attribute, cc rust-lang#94978) - rust-lang#94997 (debuginfo: Fix ICE when generating name for type that produces a layout error.) - rust-lang#95000 (Fixed wrong type name in comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2022
…ostic, r=davidtwco Use `Parser.create_snapshot_for_diagnostic` instead of `Parser.clone()` Use [`create_snapshot_for_diagnostic`](https://github.com/rust-lang/rust/blob/cd119057160cedea245aa2679add56723f3dc784/compiler/rustc_parse/src/parser/diagnostics.rs#L214-L223) I implemented in rust-lang#94731 instead of `self.clone()` to avoid duplicate unclosed delims errors being emitted when the `Parser` is dropped.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 23, 2022
…s-create-snapshot-for-diagnostic, r=Dylan-DPC Replace `this.clone()` with `this.create_snapshot_for_diagnostic()` Use [`create_snapshot_for_diagnostic`](https://github.com/rust-lang/rust/blob/cd119057160cedea245aa2679add56723f3dc784/compiler/rustc_parse/src/parser/diagnostics.rs#L214-L223) I implemented in rust-lang#94731 instead of `this.clone()` to avoid duplicate errors about unclosed delims being emitted when the `Parser` is dropped.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 12, 2022
…gnostic-in-rustc-expand, r=Dylan-DPC Use `create_snapshot_for_diagnostic` instead of `clone` for `Parser` Use [`create_snapshot_for_diagnostic`](https://github.com/rust-lang/rust/blob/cd119057160cedea245aa2679add56723f3dc784/compiler/rustc_parse/src/parser/diagnostics.rs#L214-L223) I implemented in rust-lang#94731 instead of `clone` to avoid duplicate unclosed delims errors being emitted when the `Parser` is dropped. I missed this one in rust-lang#95068.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 12, 2022
…ostic-in-rustc-expand, r=Dylan-DPC Use `create_snapshot_for_diagnostic` instead of `clone` for `Parser` Use [`create_snapshot_for_diagnostic`](https://github.com/rust-lang/rust/blob/cd119057160cedea245aa2679add56723f3dc784/compiler/rustc_parse/src/parser/diagnostics.rs#L214-L223) I implemented in rust-lang#94731 instead of `clone` to avoid duplicate unclosed delims errors being emitted when the `Parser` is dropped. I missed this one in rust-lang#95068.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #91020