Normalize projections under binders#85499
Conversation
jackh726
left a comment
There was a problem hiding this comment.
Looks like:
- Some cleanup in the pretty code needed
- Overflow evaluating a couple tests; one never finished, the other regresses on diagnostic
- Being able to normalize earlier leads to some errors that would happen later being suppressed; this is probably fine.
Overall though, I think this is close.
src/test/ui/associated-types/hr-associated-type-projection-1.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I got bored of this after 6...
|
Will this fix #76956 as well? |
Probably |
|
I think this also fixes #56556 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
47fa136 to
c101d40
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit c101d40e59f42ac2c15aca8cccb3b19d32591834 with merge ce300333714ca415579d146d0042b1adfa9809ab... |
|
☀️ Try build successful - checks-actions |
|
Queued ce300333714ca415579d146d0042b1adfa9809ab with parent 657bc01, future comparison URL. |
|
Finished benchmarking try commit (ce300333714ca415579d146d0042b1adfa9809ab): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit a7349767432e244aca61bba7f7faba0c6ab206ac with merge eaaba9d60da06713d4f80ef5a069307b3a772d2b... |
|
☀️ Try build successful - checks-actions |
|
Thanks @Alexendoo I'll take a look :) |
Fixes #70243
Fixes #70120
Fixes #62529
Fixes #87219
Issues to followup on after (probably fixed, but no test added here):
#76956
#56556
#79207
#85636
r? @nikomatsakis