Skip to content

Normalize projections under binders#85499

Merged
bors merged 5 commits intorust-lang:masterfrom
jackh726:assoc-type-norm-rebase
Aug 25, 2021
Merged

Normalize projections under binders#85499
bors merged 5 commits intorust-lang:masterfrom
jackh726:assoc-type-norm-rebase

Conversation

@jackh726
Copy link
Member

@jackh726 jackh726 commented May 20, 2021

Fixes #70243
Fixes #70120
Fixes #62529
Fixes #87219

Issues to followup on after (probably fixed, but no test added here):
#76956
#56556
#79207
#85636

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2021
Copy link
Member Author

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like:

  • Some cleanup in the pretty code needed
  • Overflow evaluating a couple tests; one never finished, the other regresses on diagnostic
  • Being able to normalize earlier leads to some errors that would happen later being suppressed; this is probably fine.

Overall though, I think this is close.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got bored of this after 6...

@smmalis37
Copy link
Contributor

Will this fix #76956 as well?

@jackh726
Copy link
Member Author

Will this fix #76956 as well?

Probably

@SkiFire13
Copy link
Contributor

I think this also fixes #56556

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@jackh726 jackh726 force-pushed the assoc-type-norm-rebase branch from 47fa136 to c101d40 Compare June 1, 2021 00:31
@jackh726
Copy link
Member Author

jackh726 commented Jun 1, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2021
@bors
Copy link
Collaborator

bors commented Jun 1, 2021

⌛ Trying commit c101d40e59f42ac2c15aca8cccb3b19d32591834 with merge ce300333714ca415579d146d0042b1adfa9809ab...

@bors
Copy link
Collaborator

bors commented Jun 1, 2021

☀️ Try build successful - checks-actions
Build commit: ce300333714ca415579d146d0042b1adfa9809ab (ce300333714ca415579d146d0042b1adfa9809ab)

@rust-timer
Copy link
Collaborator

Queued ce300333714ca415579d146d0042b1adfa9809ab with parent 657bc01, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (ce300333714ca415579d146d0042b1adfa9809ab): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2021
@jackh726
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 10, 2021
@bors
Copy link
Collaborator

bors commented Jun 10, 2021

⌛ Trying commit a7349767432e244aca61bba7f7faba0c6ab206ac with merge eaaba9d60da06713d4f80ef5a069307b3a772d2b...

@bors
Copy link
Collaborator

bors commented Jun 10, 2021

☀️ Try build successful - checks-actions
Build commit: eaaba9d60da06713d4f80ef5a069307b3a772d2b (eaaba9d60da06713d4f80ef5a069307b3a772d2b)

@jackh726
Copy link
Member Author

Thanks @Alexendoo I'll take a look :)

@Emilgardis Emilgardis mentioned this pull request Sep 11, 2021
@jackh726 jackh726 mentioned this pull request May 4, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet