Introduce `hir::ExprKind::Let` - Take 2#80357

Merged

bors merged 2 commits intorust-lang:masterfrom

c410-f3r:new-hir-let

Aug 16, 2021

Contributor

c410-f3r commented Dec 24, 2020 •

edited

Loading

Builds on #68577 and depends on #79328.

rust-highfive assigned davidtwco

Contributor

rust-highfive commented Dec 24, 2020

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive added the S-waiting-on-review label

c410-f3r changed the title ~~New hir let~~ [WIP] Introduce hir::ExprKind::Let - Take 2

This comment has been minimized.

Sign in to view

Member

davidtwco commented Dec 31, 2020

r? @matthewjasper for after #79328 lands :)

rust-highfive assigned matthewjasper and unassigned davidtwco

c410-f3r force-pushed the new-hir-let branch from f454ae2 to 819a9e2 Compare

January 14, 2021 17:35

This comment has been minimized.

Sign in to view

matthewjasper reviewed

View reviewed changes

compiler/rustc_hir/src/hir.rs Outdated Show resolved Hide resolved

compiler/rustc_typeck/src/check/generator_interior.rs Outdated Show resolved Hide resolved

compiler/rustc_typeck/src/check/_match.rs Outdated Show resolved Hide resolved

compiler/rustc_mir_build/src/build/expr/as_place.rs Outdated Show resolved Hide resolved

compiler/rustc_mir_build/src/build/expr/into.rs Outdated Show resolved Hide resolved

compiler/rustc_ast_lowering/src/expr.rs Outdated Show resolved Hide resolved

compiler/rustc_mir_build/src/build/expr/as_rvalue.rs Outdated Show resolved Hide resolved

compiler/rustc_ast_lowering/src/expr.rs Outdated Show resolved Hide resolved

Contributor Author

c410-f3r commented Jan 15, 2021 •

edited

Loading

Hi @matthewjasper. Thanks for the review!

The current status of this PR is "pretty bare bones". Sorry for the lack of work :P
Tomorrow I will address the comments and start coding again.

c410-f3r force-pushed the new-hir-let branch from 819a9e2 to ddd87c2 Compare

January 19, 2021 23:50

This comment has been minimized.

Sign in to view

c410-f3r force-pushed the new-hir-let branch from ddd87c2 to 9b02c6a Compare

January 20, 2021 01:26

This comment has been minimized.

Sign in to view

c410-f3r force-pushed the new-hir-let branch from 9b02c6a to 906abb1 Compare

January 20, 2021 23:21

matthewjasper reviewed

View reviewed changes

compiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated Show resolved Hide resolved

compiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated Show resolved Hide resolved

compiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated Show resolved Hide resolved

compiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated Show resolved Hide resolved

compiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated Show resolved Hide resolved

compiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated Show resolved Hide resolved

compiler/rustc_mir_build/src/build/expr/looking_for_a_better_name.rs Outdated Show resolved Hide resolved

c410-f3r force-pushed the new-hir-let branch 2 times, most recently from fd37ff9 to f3c0046 Compare

February 11, 2021 18:53

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

c410-f3r force-pushed the new-hir-let branch from f3c0046 to 2a16462 Compare

February 19, 2021 13:18

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

c410-f3r force-pushed the new-hir-let branch from f854543 to 5e94631 Compare

February 28, 2021 22:09

c410-f3r changed the title ~~[WIP] Introduce hir::ExprKind::Let - Take 2~~ Introduce hir::ExprKind::Let - Take 2

c410-f3r marked this pull request as ready for review

February 28, 2021 22:12

This comment has been minimized.

Sign in to view

c410-f3r force-pushed the new-hir-let branch from 5e94631 to 269e350 Compare

February 28, 2021 23:04

matthewjasper and others added 2 commits

August 15, 2021 16:05


          Use correct drop scopes for if expressions

2d9f2ea


          Introduce hir::ExprKind::Let - Take 2

6aa9937

c410-f3r force-pushed the new-hir-let branch from e164b8c to 6aa9937 Compare

August 15, 2021 19:18

Contributor

matthewjasper commented Aug 15, 2021

1 similar comment

Contributor

matthewjasper commented Aug 15, 2021

Collaborator

bors commented Aug 15, 2021

📌 Commit 6aa9937 has been approved by matthewjasper

Collaborator

bors commented Aug 16, 2021

⌛ Testing commit 6aa9937 with merge 2a6fb9a...

Collaborator

bors commented Aug 16, 2021

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing 2a6fb9a to master...

bors mentioned this pull request

Get piece unchecked in write #83302

Merged

Contributor Author

c410-f3r commented Aug 16, 2021

At last! Thanks @matthewjasper

This was referenced Aug 16, 2021

Diagnostic tweaks #85102

Merged

Make diagnostics clearer for ? operators #86382

Merged

Add non_exhaustive_omitted_patterns lint related to rfc-2008-non_exhaustive #86809

Merged

Prefer suggestion paths which are not doc-hidden #87349

Closed

Don't mark if_let_guard as an incomplete feature #87937

Merged

Revert "Auto merge of #83417 - erikdesjardins:enableremovezsts, r=oli-obk" #88056

Merged

Member

rylev commented Aug 17, 2021

This change introduced some mixed performance results. The largest changes are performance wins, but regressions outweight improvements in terms of numbers. Interestingly, many of the regressions were in full builds, and I'm not quite sure why that would be.

As part of the performance triage process, I'm marking this as a performance regression. If you believe this performance regression to be justifiable or once you have an issue or PR that addresses this regression, please mark this PR with the label perf-regression-triaged.

@rustbot label +perf-regression

camsteffen mentioned this pull request

Fix clippy::collapsible_match with let expressions #88163

Merged

xFrednet mentioned this pull request

clippy::if_let_some_result suggests changing while to if, resulting in code with different behaviour rust-lang/rust-clippy#7586

Closed

camsteffen mentioned this pull request

Add expansion to while desugar spans #88175

Merged

Contributor

matthewjasper commented Aug 22, 2021

Hmm, I can't see anything from the by query times, so maybe this is a case where codegen has been slightly regressed resulting in a slower rustc. I'll investigate some more and create a PR soon if I find anything.

camsteffen mentioned this pull request

FP in if_same_then_else for if-let rust-lang/rust-clippy#7579

Closed

This was referenced Aug 24, 2021

Regression ICE - broken MIR under -C opt-level=s on if let Some(v) = None as Option<...> #88307

Closed

Revert "Auto merge of #80357 - c410-f3r:new-hir-let, r=matthewjasper" #88401

Closed

xFrednet mentioned this pull request

Rustup rust-lang/rust-clippy#7604

Merged

Alexendoo mentioned this pull request

ICE: panicked at 'index out of bounds: the len is 0 but the index is 0', could not prove Binder(TraitPredicate(<bool as Copy>), []) #87573

Closed

c410-f3r mentioned this pull request

Stabilize let_chains in Rust 1.64 #94927

Merged

c410-f3r mentioned this pull request

Add let_chains references rust-lang/reference#1179

Merged

jruderman mentioned this pull request

ICE "region scope ... not in scope to drop" #104172

Closed

jruderman mentioned this pull request

Exponential compile time with let in unsupported position within closure #104871

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

petrochenkov petrochenkov left review comments

matthewjasper matthewjasper left review comments

flip1995 flip1995 approved these changes

+2 more reviewers

jplatte jplatte left review comments

camsteffen camsteffen requested changes

Labels

A-HIR merged-by-bors perf-regression perf-regression-triaged S-waiting-on-bors