Promote references to constants instead of statics#67000
Merged
bors merged 23 commits intorust-lang:masterfrom Jan 11, 2020
Merged
Promote references to constants instead of statics#67000bors merged 23 commits intorust-lang:masterfrom
bors merged 23 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Dec 3, 2019
spastorino
force-pushed
the
remove-promoted-from-place
branch
4 times, most recently
from
a68a206 to
59d32ad
Compare
oli-obk
reviewed
Dec 4, 2019
spastorino
force-pushed
the
remove-promoted-from-place
branch
8 times, most recently
from
01ecd4a to
9eebc48
Compare
spastorino
force-pushed
the
remove-promoted-from-place
branch
from
9eebc48 to
1161a46
Compare
oli-obk
requested changes
Dec 10, 2019
spastorino
force-pushed
the
remove-promoted-from-place
branch
2 times, most recently
from
409de5b to
52d18bd
Compare
spastorino
changed the title
spastorino
force-pushed
the
remove-promoted-from-place
branch
from
52d18bd to
2ba78e2
Compare
spastorino
force-pushed
the
remove-promoted-from-place
branch
5 times, most recently
from
041233c to
8b262d2
Compare
bors
added
S-waiting-on-bors
Centril
added
S-waiting-on-author
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit e51eccd has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Jan 11, 2020
Promote references to constants instead of statics r? @oli-obk
Collaborator
|
☀️ Test successful - checks-azure |
This was referenced Jan 11, 2020
Merged
This was referenced Jan 14, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @oli-obk