Check arg/ret sizedness at ExprKind::Path#56045
Merged
bors merged 5 commits intorust-lang:masterfrom Nov 25, 2018
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves three problems:
unsized_locals.Sizedbounds on stable functions because of fn ptr castingThese are caused by lack of
Sizedness checks for arguments/retvals at reference sites ofFnDefitems (not call sites of the functions). Therefore we can basically add moreSizedobligations on typeck. However, addingSizedobligations arbitrarily breaks type inference; to prevent that I added a new methodrequire_type_is_sized_deferredwhich doesn't interfere usual type inference.