Skip to content

Remove unused bundled library lookup for the local crate#159571

Open
mehdiakiki wants to merge 1 commit into
rust-lang:mainfrom
mehdiakiki:rmeta-link/drop-dead-local-search
Open

Remove unused bundled library lookup for the local crate#159571
mehdiakiki wants to merge 1 commit into
rust-lang:mainfrom
mehdiakiki:rmeta-link/drop-dead-local-search

Conversation

@mehdiakiki

@mehdiakiki mehdiakiki commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

After #156735 the local crate's branch in add_native_libs_from_crate computes a list of bundled library filenames that nothing ever reads. And the only place that runs this is located in other crates not the current local one. The local crate always links its native libraries by name.

This removes that unused branch. This is a cleanup only with no change in behavior.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 19, 2026
@rustbot

rustbot commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: codegen, compiler
  • codegen, compiler expanded to 74 candidates
  • Random selection from 16 candidates

@mehdiakiki

Copy link
Copy Markdown
Contributor Author

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned davidtwco Jul 19, 2026
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit a29216c has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 20, 2026
…cal-search, r=petrochenkov

Remove unused bundled library lookup for the local crate

After rust-lang#156735 the local crate's branch in `add_native_libs_from_crate` computes a list of bundled library filenames that nothing ever reads. And the only place that runs this is located in other crates not the current local one. The local crate always links its native libraries by name.

This removes that unused branch. This is a cleanup only with no change in behavior.
rust-bors Bot pushed a commit that referenced this pull request Jul 20, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - #159600 (`rust-analyzer` subtree update)
 - #158046 (proc_macro: preserve file module spans for inner attrs)
 - #159000 (Small cleanups to the incr comp session code)
 - #159189 (Account for type alias projections in E0308 "expected/found" shortening logic)
 - #159449 (Enable single Location to issue multiple borrows)
 - #159544 (Suggest valid command-line crate names)
 - #159587 (Improve `AttrItem::span`)
 - #159594 (feat(rustc_hir_typeck): suggest `impl Fn` return for capturing closures)
 - #159597 (std: use `arc4random_buf` from libc)
 - #159599 (Resolver: Record at least 1 ambiguous trait if main decl is not a trait.)
 - #158061 (Make `pin!()` more foolproof.)
 - #159460 (Do not mark unnormalized const aliases as rigid when normalizing param env)
 - #159529 (Add regression test for nested replacement ranges in `collect_tokens`)
 - #159571 (Remove unused bundled library lookup for the local crate)
 - #159585 (Minor `TokenStream` improvements)
 - #159586 (Separate `InterpCx` usage by `ConstAnalysis` phases)
 - #159602 (Remove `ItemLike`)
 - #159603 (Clarify `push_stream`/`push_tree`)

Failed merges:

 - #159590 (Remove some dead code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants