Bring runtime symbols statics on par with foreign functions#159527
Open
Urgau wants to merge 4 commits into
Open
Bring runtime symbols statics on par with foreign functions#159527Urgau wants to merge 4 commits into
Urgau wants to merge 4 commits into
Conversation
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Jul 18, 2026
bjorn3
reviewed
Jul 19, 2026
Urgau
force-pushed
the
runtime-symbols-static-cleanup
branch
from
July 19, 2026 17:30
7c53b6a to
fea4343
Compare
This comment has been minimized.
This comment has been minimized.
Urgau
force-pushed
the
runtime-symbols-static-cleanup
branch
from
July 20, 2026 20:46
fea4343 to
778a9df
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleanups the
staticitems path when checking the runtime symbols, and brings it on par with the foreign functions check.It also fixes a bug where static only reported the invalid lint and never the suspicious lint.
Best reviewed commit by commit.
r? @GuillaumeGomez