Split IncrCompSession out of Session#159225
Open
bjorn3 wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
rustbot
added
A-LLVM
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
bjorn3
marked this pull request as draft
July 13, 2026 13:52
rustbot
added
S-waiting-on-author
bjorn3
added
the
S-blocked
This comment has been minimized.
This comment has been minimized.
This was referenced Jul 14, 2026
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
split_incr_comp_session
branch
2 times, most recently
from
July 21, 2026 09:31
da7be36 to
5b8856f
Compare
bjorn3
marked this pull request as ready for review
July 21, 2026 09:34
rustbot
added
S-waiting-on-review
Member
Author
bjorn3
removed
the
S-blocked
This comment has been minimized.
This comment has been minimized.
This will allow introducing a separate incr comp session dir for the post LTO artifacts in the future. In addition it statically encodes the lifetime of the incr comp session rather than requiring an enum behind a mutex stored in the Session.
bjorn3
force-pushed
the
split_incr_comp_session
branch
from
July 21, 2026 09:58
5b8856f to
b87b61a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow introducing a separate incr comp session dir for the post LTO artifacts in the future. In addition it statically encodes the lifetime of the incr comp session rather than requiring an enum behind a mutex stored in the Session.
Based on #159000
Part of rust-lang/compiler-team#908