Skip to content

Emit all borrowck errors at the end of borrowck#158916

Open
oli-obk wants to merge 4 commits into
rust-lang:mainfrom
oli-obk:borrowck-delayed-diags
Open

Emit all borrowck errors at the end of borrowck#158916
oli-obk wants to merge 4 commits into
rust-lang:mainfrom
oli-obk:borrowck-delayed-diags

Conversation

@oli-obk

@oli-obk oli-obk commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

cc rust-lang/rust-project-goals#713

best reviewed commit by commit.

This changes some diagnostic ordering and tainting effects on diagnostics, but generally that should be an improvement as all diagnostics are sorted by their line numbers now

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2026
@rust-log-analyzer

rust-log-analyzer commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
...............................F.................. (50/144)
.................................................. (100/144)
............................................       (144/144)

======== tests/rustdoc-gui/go-to-collapsed-elem.goml ========

[ERROR] line 40
    at `tests/rustdoc-gui/go-to-collapsed-elem.goml` line 21: Error: Node is detached from document: for command `click: "//*[@id='search']//a[@href='../test_docs/struct.Foo.html#method.must_use']"`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.Foo.html?search=t_use>


<= doc-ui tests done: 143 succeeded, 1 failed, 0 filtered out

Error: ()

@oli-obk

oli-obk commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

help! @rust-lang/rustdoc what is this error and how can it possibly be caused from borrowck changes?

@GuillaumeGomez

GuillaumeGomez commented Jul 8, 2026

Copy link
Copy Markdown
Member

It's a flaky error. Should be fixed once #158913 is merged. Restarted failed jobs.

lcnr
lcnr reviewed Jul 13, 2026
View reviewed changes

@lcnr lcnr left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit 3 and 4 overlap somewhat, when is rcx.dcx used 🤔

View changes since this review

lcnr
lcnr reviewed Jul 13, 2026
View reviewed changes
Comment thread compiler/rustc_borrowck/src/borrowck_errors.rs
impl<'diag, 'tcx> crate::MirBorrowckCtxt<'_, 'diag, 'tcx> {
pub(crate) fn dcx(&self) -> DiagCtxtHandle<'diag> {
self.infcx.dcx()
self.root_cx.dcx()

@lcnr lcnr Jul 13, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah here

View changes since the review

@lcnr

lcnr commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f06dbe0 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2026
@rust-bors

rust-bors Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #159213) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This pull request was unapproved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lcnr lcnr

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oli-obk @rust-log-analyzer @GuillaumeGomez @lcnr @rustbot