Skip to content

Promote riscv64-unknown-linux-musl to tier 2 with host tools#158766

Open
eshattow wants to merge 1 commit into
rust-lang:mainfrom
eshattow:linux-musl-riscv64-ci
Open

Promote riscv64-unknown-linux-musl to tier 2 with host tools#158766
eshattow wants to merge 1 commit into
rust-lang:mainfrom
eshattow:linux-musl-riscv64-ci

Conversation

@eshattow

@eshattow eshattow commented Jul 4, 2026

Copy link
Copy Markdown

@rustbot

rustbot commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 4, 2026
@rustbot

rustbot commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @marcoieni (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

@rustbot

This comment has been minimized.

@rust-bors

This comment has been minimized.

@eshattow
eshattow force-pushed the linux-musl-riscv64-ci branch from 6fd0979 to 4cfdb44 Compare July 5, 2026 15:19
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@eshattow
eshattow force-pushed the linux-musl-riscv64-ci branch from 4cfdb44 to 2bc2864 Compare July 5, 2026 15:30
@marcoieni

Copy link
Copy Markdown
Member

@bors try jobs=dist-riscv64-linux-musl,dist-riscv64-linux-gnu

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 7, 2026
Promote riscv64-unknown-linux-musl to tier 2 with host tools


try-job: dist-riscv64-linux-musl
try-job: dist-riscv64-linux-gnu
@rust-log-analyzer

This comment has been minimized.

@marcoieni

marcoieni commented Jul 7, 2026

Copy link
Copy Markdown
Member

Maybe the failure is due to this codex finding, which I copy-paste without editing:


[P1] New Docker image does not copy the crosstool-ng checksum patch.
Dockerfile:6 runs crosstool-ng.sh, but that script unconditionally reads /scripts/crosstool-ng-sha256-20260705.diff at crosstool-ng.sh:20. The existing RISC-V GNU image copies that file before running the script.

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2026
@rust-bors

rust-bors Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 9d14c25 failed: CI. Failed job:

@eshattow
eshattow force-pushed the linux-musl-riscv64-ci branch from 2bc2864 to 53d675c Compare July 7, 2026 14:09
@eshattow

eshattow commented Jul 7, 2026

Copy link
Copy Markdown
Author

@marcoieni writes:

Maybe the failure is due to this codex finding, which I copy-paste without editing:
...

I'd missed this, as it is a recent change to resolve the fallout of kernel.org mirrors CDN being down for several days.

Added the appropriate COPY line to the Dockerfile and pushed, thanks for the suggestion :-)

@rust-log-analyzer

This comment has been minimized.

@eshattow
eshattow force-pushed the linux-musl-riscv64-ci branch from 53d675c to 3e5f43a Compare July 8, 2026 17:15
@rustbot

rustbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@eshattow

eshattow commented Jul 8, 2026

Copy link
Copy Markdown
Author

@bors try jobs=dist-riscv64-linux-musl,dist-riscv64-linux-gnu

@rust-bors

rust-bors Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@eshattow: 🔑 Insufficient privileges: not in try users

@eshattow
eshattow requested a review from marcoieni July 9, 2026 02:08
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2026
@marcoieni

Copy link
Copy Markdown
Member

@bors try jobs=dist-riscv64-linux-musl,dist-riscv64-linux-gnu

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 10, 2026
Promote riscv64-unknown-linux-musl to tier 2 with host tools


try-job: dist-riscv64-linux-musl
try-job: dist-riscv64-linux-gnu
@rust-bors

rust-bors Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: af6bde0 (af6bde0aa65b20bb4a0f8294334d9ab4ceff9eaa)
Base parent: 31e4b84 (31e4b8481fec5ae856d786ff3b75a5bccaf33725)

@eshattow

Copy link
Copy Markdown
Author

@marcoieni this build has been tested successfully on riscv64 hardware, there is some missing address sanitizer coverage of both -gnu and -musl targets that would be appropriate for a follow-up issue but is not any blocker here now. I want to know any obvious problems with documentation changes or omissions. Also is there any requirement to add myself as a code maintainer? Thanks for your assistance, -E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants