Promote riscv64-unknown-linux-musl to tier 2 with host tools#158766
Promote riscv64-unknown-linux-musl to tier 2 with host tools#158766eshattow wants to merge 1 commit into
Conversation
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. Warning If you are changing how CI LLVM is built or linked, make sure to bump cc @jieyouxu These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @marcoieni (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6fd0979 to
4cfdb44
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4cfdb44 to
2bc2864
Compare
|
@bors try jobs=dist-riscv64-linux-musl,dist-riscv64-linux-gnu |
This comment has been minimized.
This comment has been minimized.
Promote riscv64-unknown-linux-musl to tier 2 with host tools try-job: dist-riscv64-linux-musl try-job: dist-riscv64-linux-gnu
This comment has been minimized.
This comment has been minimized.
|
Maybe the failure is due to this codex finding, which I copy-paste without editing: [P1] New Docker image does not copy the crosstool-ng checksum patch. |
|
💔 Test for 9d14c25 failed: CI. Failed job:
|
2bc2864 to
53d675c
Compare
|
@marcoieni writes:
I'd missed this, as it is a recent change to resolve the fallout of kernel.org mirrors CDN being down for several days. Added the appropriate COPY line to the Dockerfile and pushed, thanks for the suggestion :-) |
This comment has been minimized.
This comment has been minimized.
Implements MCP 982 via issue 156191
53d675c to
3e5f43a
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors try jobs=dist-riscv64-linux-musl,dist-riscv64-linux-gnu |
|
@eshattow: 🔑 Insufficient privileges: not in try users |
|
@bors try jobs=dist-riscv64-linux-musl,dist-riscv64-linux-gnu |
This comment has been minimized.
This comment has been minimized.
Promote riscv64-unknown-linux-musl to tier 2 with host tools try-job: dist-riscv64-linux-musl try-job: dist-riscv64-linux-gnu
|
@marcoieni this build has been tested successfully on riscv64 hardware, there is some missing address sanitizer coverage of both -gnu and -musl targets that would be appropriate for a follow-up issue but is not any blocker here now. I want to know any obvious problems with documentation changes or omissions. Also is there any requirement to add myself as a code maintainer? Thanks for your assistance, -E |
View all comments
MCP: rust-lang/compiler-team#982
Implements #156191