Skip to content

Handle nested inline consts in const argument checks#158640

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Shourya742:2026-07-01-reject-const-param-nesed-case
Jul 10, 2026
Merged

Handle nested inline consts in const argument checks#158640
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Shourya742:2026-07-01-reject-const-param-nesed-case

Conversation

@Shourya742

Copy link
Copy Markdown
Member

More info here: #158375 (comment)

r? @BoxyUwU

cc: @khyperia

@rustbot

rustbot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

HIR ty lowering was modified

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2026
@rustbot

rustbot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@BoxyUwU

BoxyUwU commented Jul 8, 2026

Copy link
Copy Markdown
Member

thx good catch :3 this may or may not merge conflict with #158617 so lets wait for that to land first then you can rebase this and r=me it

@bors delegate+

@rust-bors

rust-bors Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

✌️ @Shourya742, you can now approve this pull request!

If @BoxyUwU told you to "r=me" after making some further change, then please make that change and post @bors r=BoxyUwU.

View changes since this delegation.

@BoxyUwU

BoxyUwU commented Jul 8, 2026

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2026
@Shourya742

Shourya742 commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

It didn't conflicted with direct_const_args PR. Adding this to queue:

@bors r=BoxyUwU

@rust-bors

rust-bors Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 14dbd5d has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2026
rust-bors Bot pushed a commit that referenced this pull request Jul 10, 2026
Rollup of 7 pull requests

Successful merges:

 - #155429 (Support `u128`/`i128` c-variadic arguments)
 - #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`)
 - #158640 (Handle nested inline consts in const argument checks)
 - #158866 ([perf] Add explicit `Iterator::count` impl for `ChunkBy`.)
 - #158912 (Introduce new bootstrap config section for PGO configuration)
 - #159040 (Print step stack trace when bootstrap panics)
 - #159056 (Print a loud error if the configured LLDB cannot be found)
@rust-bors rust-bors Bot merged commit 6a6e646 into rust-lang:main Jul 10, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 10, 2026
rust-timer added a commit that referenced this pull request Jul 10, 2026
Rollup merge of #158640 - Shourya742:2026-07-01-reject-const-param-nesed-case, r=BoxyUwU

Handle nested inline consts in const argument checks

More info here: #158375 (comment)

r? @BoxyUwU

cc: @khyperia
@Shourya742 Shourya742 deleted the 2026-07-01-reject-const-param-nesed-case branch July 10, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants