[wiiip]: Online the panic message of (some) asserts#158589
Draft
aDotInTheVoid wants to merge 8 commits into
Draft
[wiiip]: Online the panic message of (some) asserts#158589aDotInTheVoid wants to merge 8 commits into
aDotInTheVoid wants to merge 8 commits into
Conversation
Not done on `assert!` as that's a compiler built-in Trying to avoid needing to setup a stack if that's only needed by a assert failure, by making the compiler put that in a seperate function. This may well blow up compile-times and binary-size, but is probably good for instruction-count and icache pressure (especially with bolt-pgo). But that's all conjecture for now. Based on https://tech.lgbt/@bal4e/116831903287935479 and https://crates.io/crates/fast_assert
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
☔ The latest upstream changes (presumably #159213) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not done on
assert!as that's a compiler built-inTrying to avoid needing to setup a stack if that's only needed by a assert failure, by making the compiler put that in a seperate function. This may well blow up compile-times and binary-size, but is probably good for instruction-count and icache pressure (especially with bolt-pgo). But that's all conjecture for now.
Based on https://tech.lgbt/@bal4e/116831903287935479 and https://crates.io/crates/fast_assert
r? @ghost