Auto-assign, label, and CC lang-docs (+FLS) and edition#158424
Open
traviscross wants to merge 1 commit into
Open
Auto-assign, label, and CC lang-docs (+FLS) and edition#158424traviscross wants to merge 1 commit into
traviscross wants to merge 1 commit into
Conversation
The documentation on primitives, attributes, and keywords is language documentation and should be kept synchronized with the Reference. When these files are touched, let's add the `T-lang-docs` label, CC the team (and the FLS team), and assign the issue to a team member. (For attribute documentation, we'll also include Guillaume in the rotation as he's been working on this.) For bandwidth reasons, we may still reroll assignment to libs or compiler for ordinary matters. We'll see. The `primitive_docs.rs` file churns the most and is the one we'd be most likely to hand back. When the submodule pointer for a book owned by lang-docs or edition is updated, let's CC the team and add the correct label. For edition, we want changes to `compiler/rustc_span/src/edition.rs` and the tests in `tests/ui/editions` to cause the `T-edition` label to be applied and the team to be pinged; this arranges for that as well.
traviscross
added
T-lang-docs
rustbot
added
A-meta
Contributor
|
☔ The latest upstream changes (presumably #159579) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation on primitives, attributes, and keywords is language documentation and should be kept synchronized with the Reference. When these files are touched, let's add the
T-lang-docslabel, CC the team (and the FLS team), and assign the issue to a team member. (For attribute documentation, we'll also include Guillaume in the rotation as he's been working on this.)For bandwidth reasons, we may still reroll assignment to libs or compiler for ordinary matters. We'll see. The
primitive_docs.rsfile churns the most and is the one we'd be most likely to hand back.When the submodule pointer for a book owned by lang-docs or edition is updated, let's CC the team and add the correct label.
For edition, we want changes to
compiler/rustc_span/src/edition.rsand the tests intests/ui/editionsto cause theT-editionlabel to be applied and the team to be pinged; this arranges for that as well.r? ehuss
cc @rust-lang/lang-docs @rust-lang/fls @rust-lang/edition