Rollup of 11 pull requests by matthiaskrgr · Pull Request #156378 · rust-lang/rust

matthiaskrgr · 2026-05-10T01:17:05Z

Successful merges:

Add Command::get_resolved_envs #149362 (Add Command::get_resolved_envs)
Add str::word_to_titlecase() to alloc #155705 (Add str::word_to_titlecase() to alloc)
Add mention of sendfile(2) and splice(2) to fs::copy() documentation. #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.)
Update a bunch of bootstrap dependencies to remove windows-target #156006 (Update a bunch of bootstrap dependencies to remove windows-target)
Change SwitchInt handling in dataflow analysis. #156169 (Change SwitchInt handling in dataflow analysis.)
Add regression test for issue 144329 #155188 (Add regression test for issue 144329)
error on empty export_name #155515 (error on empty export_name)
validate #[link_name = "..."] & #[link(name = "...")] parameters #155817 (validate #[link_name = "..."] & #[link(name = "...")] parameters)
remove turbofish notation + use None / Some instead of Option:: (in match documentation) #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation))
mark some panicking methods around Duration as track_caller #156133 (mark some panicking methods around Duration as track_caller)
rustc_attr_parsing: add AcceptContext::expect_string_literal #156363 (rustc_attr_parsing: add AcceptContext::expect_string_literal)

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

specifically, do not allow NULL bytes and the empty string

We call `get_switch_int_data` once for the switch and then pass that data to `apply_switch_int_edge_effect` for each switch target. The only case in practice is `MaybePlacesSwitchIntData` which does an awkward thing, maintaining an index into the discriminants and updating it on each call to `apply_switch_int_edge_effect`. This commit changes things to do more work up front in `get_switch_int_data`, in order to then do less work in `apply_switch_int_edge_effect`. This avoids the need for the `variants` and `next_discr` methods and the discriminants index. Overall it's a little simpler.

* Add `str::word_to_titlecase()` to `alloc` * Address review comment

* Add mention of sendfile(2) and splice(2) to fs::copy() documentation. * Oxford comma fix

…s, r=Mark-Simulacrum Add Command::get_resolved_envs This addition allows an end-user to inspect the environment variables that are visible to the process when it boots. Discussed in: - Tracking issue: rust-lang#149070 (partially closes) - ACP: rust-lang/libs-team#194

@rustbot

… r=Mark-Simulacrum Add `str::word_to_titlecase()` to `alloc` A small addition to rust-lang#153892. Hasn't gone through ACP, so needs libs-API signoff. @rustbot label A-Unicode T-libs-api

…riplett Add mention of sendfile(2) and splice(2) to fs::copy() documentation. Fixes rust-lang#155968 by adding mention of sendfile(2) and splice(2) from io::copy()

…=Mark-Simulacrum Update a bunch of bootstrap dependencies to remove windows-target Follow up to rust-lang#155444

@cjgillot

…ff, r=cjgillot Change `SwitchInt` handling in dataflow analysis. We call `get_switch_int_data` once for the switch and then pass that data to `apply_switch_int_edge_effect` for each switch target. The only case in practice is `MaybePlacesSwitchIntData` which does an awkward thing, maintaining an index into the discriminants and updating it on each call to `apply_switch_int_edge_effect`. This commit changes things to do more work up front in `get_switch_int_data`, in order to then do less work in `apply_switch_int_edge_effect`. This avoids the need for the `variants` and `next_discr` methods and the discriminants index. Overall it's a little simpler. r? @cjgillot

…lacrum Add regression test for issue 144329 Closes rust-lang#144329.

…r=jdonszelmann error on empty `export_name` fixes rust-lang#155495 Using an empty string as the name makes LLVM make up a name. However this name can be inconsistent between compilation units, which is UB and can cause linking errors, and some parts of LLVM just crash on the empty name (see the linked issue). As far as we know there is only one valid pattern that could use this, a `#[used]` static that is not referenced by the program at all. That is not UB, but the `export_name` is not required for that to work, just normal rust name mangling would do fine. Technically this is a breaking change, but it seems unlikely that this actually breaks code in the wild that wasn't already broken. I'll leave it up to T-lang to determine what is required here (crater run, FCW, ...), but my gut feeling is that we could just merge this and nobody would notice.

…=mejrs validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters fixes rust-lang#155776 fixes rust-lang#155484 specifically, do not allow NULL bytes and the empty string in `#[link_name = "..."]` and `#[link(name = "...")]`. Like some of the others I think this formally needs to be looked at by T-lang because these errors would not show up if not linking. The LLVM erorr on `#[linke_name = "\0"]` is emitted here, it is not e.g. target-specific. https://github.com/llvm/llvm-project/blob/d593279c0b2891f0b0c8af3f70a1a0383b4ad1b5/llvm/lib/IR/Value.cpp#L336-L342 On `#[link(name = "")]` we already error today. A NULL byte in `#[link(name = "\0")]` is caught by the linker (https://godbolt.org/z/vnz9sYbPs), using `#[link_name = ""]` makes LLVM generate a name (https://godbolt.org/z/1hWEo4cxf) which is not useful and likely to cause linker errors. r? jdonszelmann

…acrum remove turbofish notation + use None / Some instead of Option:: (in match documentation)

…r=Mark-Simulacrum mark some panicking methods around Duration as track_caller Currently when they panic it looks like this ``` 0.005045 ---- instant_checked_duration_since_nopanic stdout ---- 0.000039 0.000009 thread 'instant_checked_duration_since_nopanic' (2) panicked at /home/runner/work/miri-test-libstd/miri-test-libstd/rust-src-patched/library/std/src/time.rs:445:33: 0.000007 overflow when subtracting duration from instant 0.000006 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace 0.000007 note: in Miri, you may have to set `MIRIFLAGS=-Zmiri-env-forward=RUST_BACKTRACE` for the environment variable to have an effect ``` That's pretty useless. Also fix the panic message while we are at it.

…literal, r=JonathanBrouwer `rustc_attr_parsing`: add `AcceptContext::expect_string_literal`

matthiaskrgr · 2026-05-10T01:17:21Z

@bors r+ rollup=never p=5

rust-bors · 2026-05-10T01:17:24Z

📌 Commit ddecb76 has been approved by matthiaskrgr

It is now in the queue for this repository.

Rollup of 11 pull requests Successful merges: - #149362 (Add Command::get_resolved_envs) - #155705 (Add `str::word_to_titlecase()` to `alloc`) - #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.) - #156006 (Update a bunch of bootstrap dependencies to remove windows-target) - #156169 (Change `SwitchInt` handling in dataflow analysis.) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters) - #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation)) - #156133 (mark some panicking methods around Duration as track_caller) - #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)

rust-log-analyzer · 2026-05-10T03:14:08Z

The job x86_64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test expr_store::tests::body::array_element_cfg ... ok
test expr_store::scope::tests::while_let_adds_binding ... ok
test expr_store::tests::body::async_fn_weird_param_patterns ... ok
test expr_store::tests::body::block::inner_item_smoke ... ok
error: test failed, to rerun pass `-p hir-def --lib`

Caused by:
  process didn't exit successfully: `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/hir_def-c439368f2b64a049 '--skip=tests::smoke_test_real_sysroot_cargo' --skip=check_code_formatting -Z unstable-options --format json` (signal: 11, SIGSEGV: invalid memory reference)
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Build completed unsuccessfully in 1:05:42
  local time: Sun May 10 03:13:51 UTC 2026
  network time: Sun, 10 May 2026 03:13:52 GMT
##[error]Process completed with exit code 1.

rust-bors · 2026-05-10T03:15:10Z

💔 Test for 488aaf6 failed: CI. Failed job:

auto - x86_64-gnu-llvm-21-1 (web logs, enhanced plaintext logs)

matthiaskrgr · 2026-05-10T03:27:52Z

@bors retry

Rollup of 11 pull requests Successful merges: - #149362 (Add Command::get_resolved_envs) - #155705 (Add `str::word_to_titlecase()` to `alloc`) - #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.) - #156006 (Update a bunch of bootstrap dependencies to remove windows-target) - #156169 (Change `SwitchInt` handling in dataflow analysis.) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters) - #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation)) - #156133 (mark some panicking methods around Duration as track_caller) - #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)

rust-log-analyzer · 2026-05-10T05:44:49Z

The job dist-x86_64-netbsd failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-05-10T05:45:25Z

💔 Test for 16efdfa failed: CI. Failed job:

auto - dist-x86_64-netbsd (web logs, enhanced plaintext logs)

matthiaskrgr · 2026-05-10T06:05:02Z

@bors retry

rust-bors · 2026-05-10T06:05:53Z

⌛ Testing commit ddecb76 with merge d1961be...

Workflow: https://github.com/rust-lang/rust/actions/runs/25621437092

Rollup of 11 pull requests Successful merges: - #149362 (Add Command::get_resolved_envs) - #155705 (Add `str::word_to_titlecase()` to `alloc`) - #155970 (Add mention of sendfile(2) and splice(2) to fs::copy() documentation.) - #156006 (Update a bunch of bootstrap dependencies to remove windows-target) - #156169 (Change `SwitchInt` handling in dataflow analysis.) - #155188 (Add regression test for issue 144329) - #155515 (error on empty `export_name`) - #155817 (validate `#[link_name = "..."]` & `#[link(name = "...")]` parameters) - #156107 (remove turbofish notation + use None / Some instead of Option:: (in match documentation)) - #156133 (mark some panicking methods around Duration as track_caller) - #156363 (`rustc_attr_parsing`: add `AcceptContext::expect_string_literal`)

schneems and others added 24 commits March 2, 2026 14:42

Add Command::get_resolved_envs

5ed5b26

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

error on empty export_name

d0ea88e

validate link name parameter

c08b9ab

specifically, do not allow NULL bytes and the empty string

Add regression test for issue 144329

fd2e542

Update a bunch of bootstrap dependencies to remove windows-target

7eb6a20

remove turbofish notation + use None / Some instead of Option::

a80af22

mark some panicking methods around Duration as track_caller

09dc7fc

replace leftover call to ArgParser::list with AcceptContext::expect_lits

a275453

rustc_attr_parsing: improve error message for codegen attributes

9097f5b

rustc_attr_parsing: add AcceptContext::expect_string_literal

dcdba78

Add str::word_to_titlecase() to alloc

40da877

* Add `str::word_to_titlecase()` to `alloc` * Address review comment

Add mention of sendfile(2) and splice(2) to fs::copy() documentation.

f4adc40

* Add mention of sendfile(2) and splice(2) to fs::copy() documentation. * Oxford comma fix

Rollup merge of rust-lang#155705 - Jules-Bertholet:word-to-titlecase,…

2728204

… r=Mark-Simulacrum Add `str::word_to_titlecase()` to `alloc` A small addition to rust-lang#153892. Hasn't gone through ACP, so needs libs-API signoff. @rustbot label A-Unicode T-libs-api

Rollup merge of rust-lang#155970 - tomilepp:issue-155968-fix, r=josht…

9165dbf

…riplett Add mention of sendfile(2) and splice(2) to fs::copy() documentation. Fixes rust-lang#155968 by adding mention of sendfile(2) and splice(2) from io::copy()

Rollup merge of rust-lang#156006 - bjorn3:bootstrap_no_import_libs, r…

0711aa9

…=Mark-Simulacrum Update a bunch of bootstrap dependencies to remove windows-target Follow up to rust-lang#155444

Rollup merge of rust-lang#155188 - DaniPopes:144329-test, r=Mark-Simu…

dd0746b

…lacrum Add regression test for issue 144329 Closes rust-lang#144329.

Rollup merge of rust-lang#156107 - Cheese-Space:patch-1, r=Mark-Simul…

6fffff9

…acrum remove turbofish notation + use None / Some instead of Option:: (in match documentation)

Rollup merge of rust-lang#156363 - scrabsha:attributes/expect-string-…

ddecb76

…literal, r=JonathanBrouwer `rustc_attr_parsing`: add `AcceptContext::expect_string_literal`

rust-bors Bot added the rollup A PR which is a rollup label May 10, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2026

rust-bors Bot mentioned this pull request May 10, 2026

Add Command::get_resolved_envs #149362

Open

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests#156378

Rollup of 11 pull requests#156378
matthiaskrgr wants to merge 24 commits intorust-lang:mainfrom
matthiaskrgr:rollup-NO89xfV

matthiaskrgr commented May 10, 2026

Uh oh!

matthiaskrgr commented May 10, 2026

Uh oh!

rust-bors Bot commented May 10, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 10, 2026

Uh oh!

rust-bors Bot commented May 10, 2026

Uh oh!

matthiaskrgr commented May 10, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 10, 2026

Uh oh!

rust-bors Bot commented May 10, 2026

Uh oh!

matthiaskrgr commented May 10, 2026

Uh oh!

rust-bors Bot commented May 10, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Conversation

matthiaskrgr commented May 10, 2026

Uh oh!

matthiaskrgr commented May 10, 2026

Uh oh!

rust-bors Bot commented May 10, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 10, 2026

Uh oh!

rust-bors Bot commented May 10, 2026

Uh oh!

matthiaskrgr commented May 10, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 10, 2026

Uh oh!

rust-bors Bot commented May 10, 2026

Uh oh!

matthiaskrgr commented May 10, 2026

Uh oh!

rust-bors Bot commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

rust-bors Bot commented May 10, 2026 •

edited

Loading