Skip to content

Rollup of 3 pull requests#156113

Merged
rust-bors[bot] merged 6 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-yXpNY1L
May 3, 2026
Merged

Rollup of 3 pull requests#156113
rust-bors[bot] merged 6 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-yXpNY1L

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

Jules-Bertholet and others added 6 commits April 19, 2026 19:01
…ate, r=BoxyUwU

Add `const_param_ty_unchecked` gate

Add `const_param_ty_unchecked` internal feature gate to skip `ConstParamTy_` trait enforcement on type. Provides an escape hatch for writing tests and examples that use const generics without needing to ensure all fields implement `ConstParamTy_`.

r? BoxyUwU
…r=folkertdev

const-stabilize `char::is_control()`
…kertdev

VaList::next_arg: track_caller for better Miri errors

The test diff should explain why this is better. :)

r? @folkertdev
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label May 3, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 3, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 3, 2026

📌 Commit 06354f4 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 3, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 3, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 19m 42s
Pushing ad3a598 to main...

@rust-bors rust-bors Bot merged commit ad3a598 into rust-lang:main May 3, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 3, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#153536 Add const_param_ty_unchecked gate 065d619fb04b9722cd567d201e5d75f3556f1d3e (link)
#155528 const-stabilize char::is_control() 3f909b7e2ad84e44db77781c8bd123dcaba44b3d (link)
#156086 VaList::next_arg: track_caller for better Miri errors d1c15e0b95e458a950b22a253e14a7936b62f093 (link)

previous master: 818811b3cd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 818811b (parent) -> ad3a598 (this PR)

Test differences

Show 161 test diffs

Stage 1

  • [ui] tests/ui/const-generics/adt_const_params/const_param_ty_unchecked-unsupported.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/adt_const_params/const_param_ty_unchecked.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/adt_const_params/const_param_ty_unchecked_fail.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/const-generics/adt_const_params/const_param_ty_unchecked-unsupported.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/adt_const_params/const_param_ty_unchecked.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/adt_const_params/const_param_ty_unchecked_fail.rs: [missing] -> pass (J0)

Additionally, 155 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ad3a598ca4bc7c68bcbbce3e0d3be9a7618df190 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. i686-gnu-nopt-1: 1h 37m -> 2h 10m (+34.6%)
  2. x86_64-gnu: 1h 49m -> 2h 23m (+30.2%)
  3. pr-check-1: 27m 55s -> 35m 20s (+26.6%)
  4. dist-x86_64-apple: 1h 36m -> 1h 59m (+24.2%)
  5. dist-powerpc64le-linux-musl: 1h 15m -> 1h 33m (+23.8%)
  6. dist-x86_64-msvc-alt: 2h 52m -> 2h 12m (-23.1%)
  7. dist-powerpc64le-linux-gnu: 1h 17m -> 1h 34m (+21.7%)
  8. dist-armv7-linux: 1h 14m -> 1h 30m (+20.8%)
  9. dist-s390x-linux: 1h 29m -> 1h 11m (-19.9%)
  10. dist-armhf-linux: 1h 27m -> 1h 11m (-18.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (ad3a598): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.1% [0.1%, 0.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [0.1%, 0.1%] 1

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-7.8%, -0.5%] 5
All ❌✅ (primary) - - 0

Cycles

Results (secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.7% [-0.7%, -0.7%] 1
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 493.646s -> 495.343s (0.34%)
Artifact size: 394.40 MiB -> 394.42 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants