Check redundant_explicit_links against generated URLs#156009
Conversation
redundant_explicit_links against generated URLsredundant_explicit_links against generated URLs
This comment has been minimized.
This comment has been minimized.
78cc7d7 to
52290d1
Compare
This comment has been minimized.
This comment has been minimized.
52290d1 to
4c47005
Compare
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
4c47005 to
8a48cea
Compare
|
I just noticed #156711, which seems related to broader rustdoc/compiler path-resolution work. Does that tracking issue change the desired direction for this PR? If the preferred approach is to wait for the broader item-signature resolution mechanism, I’m happy to adjust/park this, but I’d appreciate guidance so I know whether this PR is still worth pursuing. |
|
I've yet to review your PR (sorry about that), so I can't tell for certain. However, I'm inclined to believe that the feature described in that tracking issue is not relevant. Double-checking that later. |
|
☔ The latest upstream changes (presumably #159046) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
Fixes #155458.
rustdoc::redundant_explicit_linkschecked explicit link destinations by resolving both the label and the destination as intra-doc paths. That misses links written as local rustdoc page URLs, such asstruct.B.html, because those URLs do not appear indoc_link_resolutions.This PR keeps the existing path-resolution check and falls back to comparing the explicit destination with the local href that rustdoc would generate for the resolved label.