Reject outer attributes on `cfg_select` branches by qaijuang · Pull Request #155734 · rust-lang/rust

qaijuang · 2026-04-24T12:44:12Z

rustbot · 2026-04-24T14:42:13Z

Some changes occurred in compiler/rustc_attr_parsing

rustbot · 2026-04-24T14:42:16Z

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 17 candidates

rustbot · 2026-04-25T10:44:36Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

JonathanBrouwer · 2026-04-25T12:30:34Z

@bors r+ rollup

rust-bors · 2026-04-25T12:30:37Z

📌 Commit 4bb2b07 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…=JonathanBrouwer Lint doc comments in cfg_select branches Fixes rust-lang#155701.

…uwer Rollup of 6 pull requests Successful merges: - #154803 (Fix ICE from cfg_attr_trace ) - #155485 (Add an edge-case test for `--remap-path-prefix` for `rustc` & `rustdoc`) - #155659 (cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`) - #155696 (Add a higher-level API for parsing attributes) - #155734 (Lint doc comments in cfg_select branches) - #155769 (triagebot.toml: Ping Enselic when tests/debuginfo/basic-stepping.rs changes)

fmease · 2026-04-25T16:09:11Z

This PR allows more code to compile, so it's a language change and technically needs a T-lang FCP.

cc @rust-lang/lang

fmease · 2026-04-25T16:15:32Z

I'm sorry

@bors r-

rust-bors · 2026-04-25T16:15:38Z

This pull request was unapproved.

This PR was contained in a rollup (#155773), which was unapproved.

View changes since this unapproval

folkertdev

The FCP is very technically here, given this was just stabilized and I think not erroring on a doc comment in that position is very much in the spirit of the feature stabilization.

Nevertheless, let's at least let T-lang decide what they want to do here.

View changes since this review

JonathanBrouwer · 2026-05-08T09:14:05Z

@bors squash

* Lint doc comments in cfg_select branches * test with multi-line doc comment Co-authored-by: Copilot <copilot@github.com> * Reject outer attributes on `cfg_select` branches * address nits and gotchas Co-authored-by: Copilot <copilot@github.com> * one more test Co-authored-by: Copilot <copilot@github.com> * avoid snapshotting and classify recovered doc comments directly

rust-bors · 2026-05-08T09:14:26Z

🔨 6 commits were squashed into d42a92b.

JonathanBrouwer · 2026-05-08T09:17:38Z

@bors r+ rollup
I think all concerns are resolved now, since it's an error

rust-bors · 2026-05-08T09:17:41Z

📌 Commit d42a92b has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 7 pull requests Successful merges: - #156236 (resolve: Remove `MacroData`) - #156298 (Rename the unstable integer `extend` function to `widen`) - #154498 (turn some long-deprecated -C options into errors) - #155734 (Reject outer attributes on `cfg_select` branches) - #156123 (Simplify the creation of synthetic HIR.) - #156175 (Dep graph cleanups) - #156214 (Do not cache `lints_that_dont_need_to_run` across sessions)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 24, 2026

qaijuang force-pushed the cfg-select-doc-comment branch from fb8cf2e to 9c49112 Compare April 24, 2026 14:12

folkertdev reviewed Apr 24, 2026

View reviewed changes

Comment thread tests/ui/lint/unused/unused-doc-comments-for-macros.rs Outdated

qaijuang marked this pull request as ready for review April 24, 2026 14:42

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 24, 2026

rustbot assigned JonathanBrouwer Apr 24, 2026

qaijuang requested a review from folkertdev April 24, 2026 16:59

JonathanBrouwer reviewed Apr 25, 2026

View reviewed changes

Comment thread compiler/rustc_attr_parsing/src/attributes/cfg_select.rs Outdated

JonathanBrouwer requested changes Apr 25, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 25, 2026

Rollup merge of rust-lang#155734 - qaijuang:cfg-select-doc-comment, r…

054e0eb

…=JonathanBrouwer Lint doc comments in cfg_select branches Fixes rust-lang#155701.

JonathanBrouwer mentioned this pull request Apr 25, 2026

Rollup of 6 pull requests #155773

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2026

folkertdev reviewed Apr 25, 2026

View reviewed changes

Comment thread tests/ui/lint/unused/unused-doc-comments-for-macros.rs Outdated

qaijuang requested a review from folkertdev April 25, 2026 23:46

JonathanBrouwer requested changes Apr 26, 2026

View reviewed changes

Comment thread tests/ui/macros/cfg_select.stderr Outdated

Comment thread tests/ui/macros/cfg_select.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2026

qaijuang requested a review from JonathanBrouwer April 26, 2026 13:08

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2026

JonathanBrouwer requested changes Apr 26, 2026

View reviewed changes

Comment thread tests/ui/macros/cfg_select.stderr

Comment thread compiler/rustc_parse/src/parser/cfg_select.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2026

qaijuang requested a review from JonathanBrouwer April 26, 2026 14:52

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2026

fmease reviewed Apr 26, 2026

View reviewed changes

Comment thread compiler/rustc_parse/src/parser/cfg_select.rs Outdated

qaijuang requested a review from fmease April 26, 2026 16:07

This comment has been minimized.

Sign in to view

rust-bors Bot force-pushed the cfg-select-doc-comment branch from c04993f to d42a92b Compare May 8, 2026 09:14

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2026

JonathanBrouwer mentioned this pull request May 8, 2026

Rollup of 7 pull requests #156305

Merged

rust-bors Bot merged commit 6133b7e into rust-lang:main May 8, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone May 8, 2026

qaijuang deleted the cfg-select-doc-comment branch May 9, 2026 07:12

Uh oh!

Conversation

qaijuang commented Apr 24, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 24, 2026

Uh oh!

rustbot commented Apr 24, 2026

Uh oh!

Uh oh!

rustbot commented Apr 25, 2026

Uh oh!

JonathanBrouwer commented Apr 25, 2026

Uh oh!

rust-bors Bot commented Apr 25, 2026

Uh oh!

fmease commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease commented Apr 25, 2026

Uh oh!

rust-bors Bot commented Apr 25, 2026

Uh oh!

folkertdev left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JonathanBrouwer commented May 8, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 8, 2026

Uh oh!

JonathanBrouwer commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented May 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

qaijuang commented Apr 24, 2026 •

edited by rustbot

Loading

fmease commented Apr 25, 2026 •

edited

Loading

folkertdev left a comment •

edited by rustbot

Loading

JonathanBrouwer commented May 8, 2026 •

edited

Loading