Migration of `LintDiagnostic` - part 2 by GuillaumeGomez · Pull Request #153016 · rust-lang/rust

GuillaumeGomez · 2026-02-23T14:22:01Z

Follow-up of #152933.

More LintDiagnostic items being migrated to Diagnostic.

r? @JonathanBrouwer

…ty in a `Diagnostic` message is not emitted

rustbot · 2026-02-23T14:22:05Z

HIR ty lowering was modified

cc @fmease

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

rustbot · 2026-02-23T14:22:07Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

Kivooeo

i'm not sure if you want it to be reviewed specifically by Jonathan (i mean, you specified it but anyway)

feel free to r=me with ci green

View changes since this review

GuillaumeGomez · 2026-02-23T14:35:16Z

@Kivooeo Thanks a lot! But yeah, this is something me and @JonathanBrouwer are doing together so I'd prefer for them to take a look in any case (although it should be simpler since you already reviewed it 😉 ).

compiler/rustc_middle/src/lint.rs

JonathanBrouwer

r=me,Kivooeo if perf is not negative

@bors try @rust-timer queue

View changes since this review

Migration of `LintDiagnostic` - part 2

JonathanBrouwer · 2026-02-23T14:40:24Z

@rust-timer queue
Looks like rust-timer still doesn't listen to approve messages...

rust-bors · 2026-02-23T16:52:01Z

☀️ Try build successful (CI)
Build commit: 1179646 (117964613acaf6f5b70bfd2a6cd73567ae93f2a5, parent: eeb94be79adc9df7a09ad0b2421f16e60e6d932c)

rust-timer · 2026-02-23T17:31:40Z

Finished benchmarking commit (1179646): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.5%	[4.5%, 4.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.2%	[-5.2%, -5.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-4.1%, -2.7%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.498s -> 480.499s (-0.21%)
Artifact size: 395.88 MiB -> 397.93 MiB (0.52%)

GuillaumeGomez · 2026-02-23T17:36:25Z

No change in perf, let's go. =D

@bors r=JonathanBrouwer,Kivooeo rollup

rust-bors · 2026-02-23T17:36:27Z

📌 Commit b8f5241 has been approved by JonathanBrouwer,Kivooeo

It is now in the queue for this repository.

JonathanBrouwer · 2026-02-23T17:37:12Z

@bors r=JonathanBrouwer,Kivooeo rollup

rust-bors · 2026-02-23T17:37:15Z

📌 Commit b8f5241 has been approved by JonathanBrouwer,Kivooeo

It is now in the queue for this repository.

…uwer Rollup of 14 pull requests Successful merges: - #153007 (`rust-analyzer` subtree update) - #152670 (Simplify ThinLTO handling) - #152768 (Enable autodiff in ci for all major os) - #152908 (Enable rust.remap-debuginfo in the dist profile) - #152999 (Check importing `crate`/`$crate`/`super` after handling `self`) - #152003 (Reflection TypeId::trait_info_of) - #152976 (Revert relative paths for std links in rustc-docs) - #152985 (Port `#[feature]` to the new attribute system) - #152989 (Port `#[rustc_inherit_overflow_checks]` to the new attribute parsers) - #152991 (fix interpreter tracing output) - #153004 (Superficial tweaks to the query modifier docs in `rustc_middle::query::modifiers`) - #153008 (bootstrap.compiler.toml: update name of primary branch) - #153016 (Migration of `LintDiagnostic` - part 2) - #153020 (rustdoc: Improve sentence for documented empty impl blocks) Failed merges: - #152988 (Port `#[register_tool]` to the new attribute system)

@JonathanBrouwer

Rollup merge of #153016 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer,Kivooeo Migration of `LintDiagnostic` - part 2 Follow-up of #152933. More `LintDiagnostic` items being migrated to `Diagnostic`. r? @JonathanBrouwer

GuillaumeGomez added 7 commits February 23, 2026 11:30

Add TyCtxt::emit_diag_node_span_lint method

9436e6e

Migrate rustc_borrowck to use TyCtxt::emit_diag_node_span_lint

119b87f

Migrate rustc_codegen_ssa to use TyCtxt::emit_diag_node_span_lint

1a426a0

Migrate rustc_const_eval to use TyCtxt::emit_diag_node_span_lint

ab3d14c

Migrate rustc_hir_analysis to use TyCtxt::emit_diag_node_span_lint

b8677e2

Return earlier in diag_lint_level to prevent cases where a printed …

266fe95

…ty in a `Diagnostic` message is not emitted

Migrate rustc_hir_typeck to use TyCtxt::emit_diag_node_span_lint

b8f5241

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 23, 2026

rustbot assigned JonathanBrouwer Feb 23, 2026

Kivooeo approved these changes Feb 23, 2026

View reviewed changes

JonathanBrouwer reviewed Feb 23, 2026

View reviewed changes

compiler/rustc_middle/src/lint.rs Show resolved Hide resolved

JonathanBrouwer approved these changes Feb 23, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Feb 23, 2026

Auto merge of #153016 - GuillaumeGomez:migrate-diag, r=<try>

1179646

Migration of `LintDiagnostic` - part 2

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 23, 2026

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 23, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2026

JonathanBrouwer mentioned this pull request Feb 23, 2026

Rollup of 14 pull requests #153026

Merged

rust-bors bot merged commit b55a3e4 into rust-lang:main Feb 24, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Feb 24, 2026

GuillaumeGomez deleted the migrate-diag branch February 24, 2026 10:11

Uh oh!

Comments

Conversation

GuillaumeGomez commented Feb 23, 2026

Uh oh!

rustbot commented Feb 23, 2026

Uh oh!

rustbot commented Feb 23, 2026

Uh oh!

Kivooeo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Feb 23, 2026

Uh oh!

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Feb 23, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 23, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Feb 23, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

GuillaumeGomez commented Feb 23, 2026

Uh oh!

rust-bors bot commented Feb 23, 2026

Uh oh!

JonathanBrouwer commented Feb 23, 2026

Uh oh!

rust-bors bot commented Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kivooeo left a comment •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading