Skip to content

deny-by-default & report in deps uninhabited_static#152853

Open
WaffleLapkin wants to merge 1 commit intorust-lang:mainfrom
WaffleLapkin:deny_uninhabited_static
Open

deny-by-default & report in deps uninhabited_static#152853
WaffleLapkin wants to merge 1 commit intorust-lang:mainfrom
WaffleLapkin:deny_uninhabited_static

Conversation

@WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Feb 19, 2026 •
edited
Loading

The lint was introduced as a FCW in #78324 and landed in rust 1.49.0 (5 years ago); see also #74840.

Per the discussion in #149518 (comment).

cc @fmease @scottmcm @traviscross

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2026

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 15 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin WaffleLapkin force-pushed the deny_uninhabited_static branch from b5caed3 to 8bf6c59 Compare February 19, 2026 14:11
@traviscross traviscross added T-lang Relevant to the language team needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Feb 19, 2026
@chenyukang
Copy link
Member

chenyukang commented Feb 24, 2026

@bors r=chenyukang

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 24, 2026

📌 Commit 8bf6c59 has been approved by chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2026
@chenyukang
Copy link
Member

chenyukang commented Feb 24, 2026

seems need the decision from language team.
@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2026
@theemathas theemathas added S-waiting-on-t-lang Status: Awaiting decision from T-lang and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2026
@scottmcm
Copy link
Member

scottmcm commented Feb 25, 2026

Since it's still just a lint, I'd be fine to accept this under meeting consensus. (Hopefully we'll discuss it today.)

@traviscross
Copy link
Contributor

traviscross commented Feb 25, 2026

We talked about this in the meeting today. Makes sense. Let's propose to do it.

@rfcbot fcp merge lang

@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Feb 25, 2026 •
edited by scottmcm
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 25, 2026
@rust-rfcbot
Copy link
Collaborator

rust-rfcbot commented Feb 25, 2026

🔔 This is now entering its final comment period, as per the review above. 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@chenyukang chenyukang

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang S-waiting-on-t-lang Status: Awaiting decision from T-lang T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@WaffleLapkin @rustbot @rust-log-analyzer @chenyukang @scottmcm @traviscross @rust-rfcbot @theemathas