librustdoc: Make RenderOptions boolean fields into newtypes

[jefftt]

closes #87752

[rustbot]

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rust-log-analyzer]

The job aarch64-gnu-llvm-20-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    |
note: associated function defined here
   --> src/librustdoc/formats/cache.rs:146:19
    |
146 |     pub(crate) fn new(document_private: DocumentPrivate, document_hidden: DocumentHidden) -> Self {
    |                   ^^^ ---------------------------------  -------------------------------
help: try wrapping the expression in `config::DocumentPrivate`
    |
 75 |     let cache = Cache::new(config::DocumentPrivate(false), false);
    |                            ++++++++++++++++++++++++     +
help: try wrapping the expression in `config::DocumentHidden`
    |
 75 |     let cache = Cache::new(false, config::DocumentHidden(false));
    |                                   +++++++++++++++++++++++     +

For more information about this error, try `rustc --explain E0308`.
[RUSTC-TIMING] rustdoc test:true 12.456
error: could not compile `rustdoc` (lib test) due to 1 previous error

[fmease]

Could you please turn all of them into enum { Yes, No }, that's what's more conventional in this repo (and also what Esteban suggested back then (see the PR linked from the issue)).

[notriddle]

r? @fmease

[rustbot]

fmease is currently at their maximum review capacity.
They may take a while to respond.

[fmease]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[bors]

☔ The latest upstream changes (presumably #148280) made this pull request unmergeable. Please resolve the merge conflicts.

[SpriteOvO]

@jefftt Hi, ping from triage team. There is a review comment needs to be resolved, would you like to take a look at it? Thanks

[GuillaumeGomez]

Closing as we decided to not go through with it.