crater experiment: de-const-stabilize UnsafeCell::get and various as_ptr methods by RalfJung · Pull Request #129399 · rust-lang/rust

RalfJung · 2024-08-22T06:19:49Z

These should not have been stabilized before const_refs_to_cell.
For now I mostly want to see whether any code out there actually uses these methods, since it shouldn't be possible to do anything useful with them...
Cc @rust-lang/wg-const-eval

rustbot · 2024-08-22T06:19:56Z

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

RalfJung · 2024-08-22T06:20:28Z

@bors try

crater experiment: de-const-stabilize UnsafeCell::get and various as_ptr methods These should not have been stabilized before const_refs_to_cell. For now I mostly want to see whether any code out there actually uses these methods, since it shouldn't be possible to do anything useful with them... Cc `@rust-lang/wg-const-eval`

bors · 2024-08-22T06:21:38Z

⌛ Trying commit c187c98 with merge 2331520...

rust-log-analyzer · 2024-08-22T06:29:57Z

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#16 2.797 Building wheels for collected packages: reuse
#16 2.798   Building wheel for reuse (pyproject.toml): started
#16 3.046   Building wheel for reuse (pyproject.toml): finished with status 'done'
#16 3.047   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132715 sha256=dfa09868353292d98f811d3efdb0d54d07389e808efc71d68e3b93c514bf8bec
#16 3.047   Stored in directory: /tmp/pip-ephem-wheel-cache-871w9awg/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#16 3.050 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#16 3.444 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#16 3.444 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#16 DONE 3.5s
---
    Checking winapi-util v0.1.9
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
  --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:71:22
   |
71 |             unsafe { (*(self as *const Self as *const UnsafeCell<*mut T>)).get() }
   |
   = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
---

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
---

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
    | |_- in this expansion of `atomic_int!`
...
411 |   atomic_int!(AtomicI8, i8);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
    | |_- in this expansion of `atomic_int!`
...
413 |   atomic_int!(AtomicU8, u8);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
    | |_- in this expansion of `atomic_int!`
...
415 |   atomic_int!(AtomicI16, i16);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

    Checking pad v0.1.6
    Checking pad v0.1.6
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
    | |_- in this expansion of `atomic_int!`
...
417 |   atomic_int!(AtomicU16, u16);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
    | |_- in this expansion of `atomic_int!`
...
420 |   atomic_int!(AtomicI32, i32);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
    | |_- in this expansion of `atomic_int!`
...
423 |   atomic_int!(AtomicU32, u32);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
    | |_- in this expansion of `atomic_int!`
...
432 |   atomic_int!(AtomicI64, i64);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:198:25
    |
122 | / macro_rules! atomic_int {
123 | |     ($atomic_type:ident, $int_type:ident) => {
124 | |         #[repr(transparent)]
125 | |         pub(crate) struct $atomic_type {
...   |
198 | |                         (*(self as *const Self as *const UnsafeCell<$int_type>)).get()
...   |
405 | |     };
406 | | }
    | |_- in this expansion of `atomic_int!`
    | |_- in this expansion of `atomic_int!`
...
441 |   atomic_int!(AtomicU64, u64);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/fallback/mod.rs:369:17
    |
106 | / macro_rules! atomic {
107 | |     ($atomic_type:ident, $int_type:ident, $align:literal) => {
108 | |         #[repr(C, align($align))]
109 | |         pub(crate) struct $atomic_type {
369 | |                 self.v.get()
    | |                 ^^^^^^^^^^^^
...   |
372 | |     };
372 | |     };
373 | | }
    | |_- in this expansion of `atomic!`
...
385 |   atomic!(AtomicI128, i128, 16);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/fallback/mod.rs:369:17
    |
106 | / macro_rules! atomic {
107 | |     ($atomic_type:ident, $int_type:ident, $align:literal) => {
108 | |         #[repr(C, align($align))]
109 | |         pub(crate) struct $atomic_type {
369 | |                 self.v.get()
    | |                 ^^^^^^^^^^^^
...   |
372 | |     };
372 | |     };
373 | | }
    | |_- in this expansion of `atomic!`
...
386 |   atomic!(AtomicU128, u128, 16);
    |
    = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

error: `UnsafeCell::<T>::get` is not yet stable as a const fn

tgross35 · 2024-08-22T06:57:12Z

    Checking winapi-util v0.1.9
error: `UnsafeCell::<T>::get` is not yet stable as a const fn
  --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/portable-atomic-1.7.0/src/imp/core_atomic.rs:71:22
   |
71 |             unsafe { (*(self as *const Self as *const UnsafeCell<*mut T>)).get() }
   |
   = help: add `#![feature(const_unsafecell_get)]` to the crate attributes to enable

Well, there's your crater :)

regressed: root results (1 different result, 1003546 regressed crates in total)

RalfJung · 2024-08-22T07:59:47Z

Yeah that's the portable-atomic crate itself also providing a const fn as_ptr(&self) -> *mut _ on an interior mutable type, similar to our own Atomic* types.

I hope there's no way to actually call that function because self has interior mutability. But we'll have a hard time testing this hypothesis because portable-atomic will fail to build. Is there some way we can substitute the crate sources of portable-atomic for this crater run...? (to make that function not be const fn)

tgross35 · 2024-08-22T08:03:47Z

I have done some ugly but functional use of [patch.crates-io] to use my own fork of compiler_builtins, e.g. #127561 (comment). Maybe that works here?

bors · 2024-08-22T08:17:44Z

☀️ Try build successful - checks-actions
Build commit: 2331520 (2331520994fdd8f5407d0fe95377391fc96ccf2c)

oli-obk · 2024-08-22T08:49:27Z

Alternatively you can use const_eval_select together with todo!() on the const side. Not the same thing, but a check whether it's actually used constly

RalfJung · 2024-08-22T09:32:40Z

Turns out there is a way to call this:

use std::cell::UnsafeCell;

const FOO2: () = {
    let mut x = 42;
    let y: &UnsafeCell<i32> = unsafe { std::mem::transmute(&x) };
    y.get();
};

Writing to this is obviously UB, though.^^

It'd be fun to figure out whether this is actually done anywhere, but I don't see a reasonably easy way to do that so 🤷

crater experiment: de-const-stabilize UnsafeCell::get

c187c98

rustbot assigned Noratrieb Aug 22, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 22, 2024

RalfJung closed this Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

crater experiment: de-const-stabilize UnsafeCell::get and various as_ptr methods#129399

crater experiment: de-const-stabilize UnsafeCell::get and various as_ptr methods#129399
RalfJung wants to merge 1 commit intorust-lang:masterfrom
RalfJung:no-const-refs-to-cell

RalfJung commented Aug 22, 2024

Uh oh!

rustbot commented Aug 22, 2024

Uh oh!

RalfJung commented Aug 22, 2024

Uh oh!

bors commented Aug 22, 2024

Uh oh!

rust-log-analyzer commented Aug 22, 2024

Uh oh!

tgross35 commented Aug 22, 2024

Uh oh!

RalfJung commented Aug 22, 2024 •

edited

Loading

Uh oh!

tgross35 commented Aug 22, 2024

Uh oh!

bors commented Aug 22, 2024

Uh oh!

oli-obk commented Aug 22, 2024

Uh oh!

RalfJung commented Aug 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

RalfJung commented Aug 22, 2024

Uh oh!

rustbot commented Aug 22, 2024

Uh oh!

RalfJung commented Aug 22, 2024

Uh oh!

bors commented Aug 22, 2024

Uh oh!

rust-log-analyzer commented Aug 22, 2024

Uh oh!

tgross35 commented Aug 22, 2024

Uh oh!

RalfJung commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Aug 22, 2024

Uh oh!

bors commented Aug 22, 2024

Uh oh!

oli-obk commented Aug 22, 2024

Uh oh!

RalfJung commented Aug 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RalfJung commented Aug 22, 2024 •

edited

Loading