coerce.site.return: make example more simple#2182
Open
tshepang wants to merge 2 commits intorust-lang:masterfrom
Open
coerce.site.return: make example more simple#2182tshepang wants to merge 2 commits intorust-lang:masterfrom
tshepang wants to merge 2 commits intorust-lang:masterfrom
Conversation
Member
tshepang
commented
Feb 19, 2026
- remove the import and use the type directly
- get the type from its original path, and not a re-export
- remove the import and use the type directly - get the type from its original path, and not a re-export
src/type-coercions.md
Outdated
| @@ -63,8 +63,7 @@ r[coerce.site.return] | |||
| For example, `x` is coerced to have type `&dyn Display` in the following: | |||
Contributor
There was a problem hiding this comment.
I think that without the use, the previous statement that x is coerced to be &dyn Display might be a bit confusing since Display is not in scope, only core::fmt::Display (or the std version)
Member
Author
There was a problem hiding this comment.
was not sure it mattered much, but now adjusted
DanielEScherzer
approved these changes
Feb 20, 2026
Contributor
DanielEScherzer
left a comment
There was a problem hiding this comment.
Makes sense to me, though I don't have merge rights to actually approve this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.