Merged
Conversation
Member
|
LLVM 15 is already our minimum. |
Member
Author
|
Whoops, I meant 17 |
Member
|
can you describe the bug? |
Member
Author
|
I haven't looked at the codegen yet, but it reports that 4905 has 3 trailing zeros |
Member
Author
|
Aha, actually it's a bug in my test (I compare against |
Contributor
|
Why is it called Sorry if this was stated elsewhere. |
Member
Author
|
That is the name used by scalars for the same operation: https://doc.rust-lang.org/std/primitive.i32.html#method.swap_bytes |
programmerjake
approved these changes
Aug 1, 2023
calebzulawski
commented
Aug 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending rust-lang/rust#114266 and ani16xN::trailing_zerosbug that I hope is fixed by LLVM 15 17Good to go.