rustup

[RalfJung]

Locally tests pass but rustc CI says they fail, let's see what happens...

Also clarify docs of cmpxchg_weak_failure_rate (Cc #2160).

[RalfJung]

Ah, tons of failures because dead stores get removed since rust-lang/rust#97158.

@oli-obk I wonder if it still makes sense to run the compile-fail test suite with optimizations? We will have to add black_box to more and more tests to prevent UB from being optimized away. We could run only the run-pass tests with optimizations.

[JakobDegen]

Yeah, it doesn't seem to make much sense to run compile-fail tests with optimizations, since post optimization code is not expected to reproduce UB. I'd be happy to do the work of putting up a PR that fixes things via #[inline(never)] or black_box or such, but at that point I'm not really sure what we're testing. It seems like we'd end up just adding optimization barriers until we're testing the same thing as the non-opt case.

[RalfJung]

All right. I disabled the opt tests entirely for now; once #2155 is fixed we can run the pass and panic tests without running the fail tests.

[RalfJung]

@bors r+

[bors]

📌 Commit 23324b7 has been approved by RalfJung

[bors]

⌛ Testing commit 23324b7 with merge 889b19e...

[bors]

💔 Test failed - checks-actions

[RalfJung]

@bors r+

[bors]

📌 Commit 4248418 has been approved by RalfJung

[bors]

⌛ Testing commit 4248418 with merge e45f2f0...

[bors]

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing e45f2f0 to master...