Allow log_panics on stable, as Rust 1.10 stabilized panic_handler#89
Closed
kevinmehall wants to merge 1 commit into
Closed
Allow log_panics on stable, as Rust 1.10 stabilized panic_handler#89kevinmehall wants to merge 1 commit into
log_panics on stable, as Rust 1.10 stabilized panic_handler#89kevinmehall wants to merge 1 commit into
Conversation
Leaving it behind a Cargo feature in preemptive compliance with RFC 1619.
Member
|
See https://crates.io/crates/log-panics for an out of crate version that also (optionally) supports backtraces. @alexcrichton thoughts on this? I don't think log_panics will stay in this crate in the long term. Do you think we should land this change to get off the nightly name, or just deprecate this function entirely? |
Member
|
@sfackler yeah I'd be fine pushing towards the log-panics crate, the feature of backtraces there alone I think makes it perhaps more useful than the implementation in this crate. |
Author
|
Sounds good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving it behind a Cargo feature in preemptive compliance with RFC 1619.