Replace cfg_if! macro with cfg_select! fallback#740
Open
clarfonthey wants to merge 1 commit into
Open
Conversation
clarfonthey
commented
Jul 17, 2026
| } | ||
| }; | ||
|
|
||
| // match if/else chains lacking a final `else` |
Contributor
Author
There was a problem hiding this comment.
We actually never used this branch, but I guess we wanted it for completeness.
clarfonthey
force-pushed
the
cfg_select
branch
2 times, most recently
from
July 17, 2026 17:35
2d67e6d to
38ce1ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I probably could have tried harder to make the macro work with the
_fallback syntax, but I didn't care enough.The main benefit this gives is rustfmt support;
cfg_select!is properly formatted, unlikecfg_if!. Additionally, it makes migrating when we eventually bump MSRV easier.