Improve error message when 'cargo owner --add' fails with a GitHub team#17056
Open
theoxfaber wants to merge 1 commit into
Open
Improve error message when 'cargo owner --add' fails with a GitHub team#17056theoxfaber wants to merge 1 commit into
theoxfaber wants to merge 1 commit into
Conversation
When adding a GitHub team as a crate owner fails with 'could not find the github team', the error now includes a hint pointing users to check their GitHub OAuth application settings. This is a common issue caused by crates.io not having permission to access the GitHub organization. Closes rust-lang#11505
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
cargo owner --add github:org:teamand the GitHub team cannot be found, the error message now includes a helpful hint directing users to check their GitHub OAuth application permissions.What does this PR do?
The underlying error from crates.io (
could not find the github team org/repo) is often caused by crates.io not having permission to access the GitHub organization, not because the team doesn't exist. This PR adds a hint to the error message pointing users to:Before
After
Closes #11505