Repository navigation
fix: emit TypeScript clients with stable Vite+ formatting - #172
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
- Lay out declarations, imports, unions, and converter expressions in the generator while retaining structural type references and import tracking. - Emit formatted runtime templates, Markdown examples, and JSON configuration, and regenerate the TypeScript golden files from their source emitters. - Enable full Vite+ checks directly on generated output before and after packing, with a fmt script for manual edits and dist excluded from formatting.
adamcavendish
force-pushed
the
adamcavendish/format-vite-plus-output
branch
from
November 9, 2026 09:30
5254d6c to
db9691f
Compare
adamcavendish
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated TypeScript clients now pass full
vp checkdirectly after installation. Declarations, imports, unions, and converter expressions receive their layout in the Rust generator, with structural type references retained for import resolution.Runtime templates, Markdown examples, and JSON configuration follow the same formatting conventions. Golden snapshots are regenerated from the emitters. Generated projects keep the existing single-quote style, exclude
dist/from formatting, and provide afmtscript for manual edits.Golden and consumer builds run
vp install && vp check && vp pack && vp checkon freshly generated files. Generation and validation require no formatter preparation step.Validation:
cargo test --locked --workspace: 1323 passed, including 91 TypeScript golden tests.just golden-typescript::build-vp: 8/8 passed on original generated output.just golden-typescript-clients::test: preserve/camelCase clients pass full checks, packing, strict declaration checks, and 42 runtime tests.