initializing the default crypto provider for electrsd#595
Closed
ulrichard wants to merge 1 commit into
Closed
Conversation
ulrichard
requested review from
RCasatta,
TheBlueMatt,
jamillambert,
oleonardolima,
tcharding and
tnull
as code owners
ulrichard
force-pushed
the
feature/crypto_provider
branch
from
59fd315 to
a711d48
Compare
tnull
reviewed
May 19, 2026
| let out_dir = PathBuf::from(std::env::var_os("OUT_DIR").unwrap()); | ||
|
|
||
| // specify the default crypto provider for rustls | ||
| let _ = CryptoProvider::install_default(ring::default_provider()); |
Collaborator
There was a problem hiding this comment.
Note that this will likely set the default for rustls workspace-wide, i.e., potentially overriding any choice any other crate makes. I don't think we should call this manually.
ulrichard
force-pushed
the
feature/crypto_provider
branch
from
a711d48 to
b9f3bfe
Compare
Contributor
Author
|
Strangely, after I did those changes to corepc, bdk-reserves showed some other errors. And after resolving the new errors, the changes here are no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I want to use electrsd v39 in bdk-reserves (bitcoindevkit/bdk-reserves#42), I ran into errors about the rustls default crypto provider not being initialized.