fix(log-analysis): rectify traceback extraction logic and add root stacktrace support#628
Open
akshayrw25 wants to merge 1 commit intomainfrom
Open
fix(log-analysis): rectify traceback extraction logic and add root stacktrace support#628akshayrw25 wants to merge 1 commit intomainfrom
akshayrw25 wants to merge 1 commit intomainfrom
Conversation
…acktrace support
- Fix fallback when "with data {" pattern not matched: use event_msg instead
of traceback_dict_str_temp (which was undefined in that branch of stcktrc-detection)
- Add fallback extraction when balanced curlies lookup fails, using
traceback_dict_str_temp
- Extract stacktrace from root-level "stacktrace" key in JSON logs (Step 2)
- Pass str(log_str_json_obj) when object is not a dict to avoid type errors
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"with data {"pattern not matched: useevent_msginstead oftraceback_dict_str_temp(which was undefined in that branch of stacktrace-detection)traceback_dict_str_tempstr(log_str_json_obj)when object is not a dict to avoid type errorsNote
Medium Risk
Changes parsing and fallback paths in traceback extraction, which can alter which stacktraces are detected and may impact downstream alerting/diagnostics. Scope is localized to log parsing but affects production observability behavior.
Overview
Improves
PythonTracebackExtractor.extract_traceback_from_dict_logto be more robust when extracting Python stacktraces from JSON logs.It fixes fallback extraction when the
"error handling"/"with data {"pattern or balanced-curly parsing fails, ensuring extraction runs against the appropriate string and that recovered tracebacks are appended. It also adds support for a root-level JSONstacktracefield and ensures non-dict JSON values are coerced tostrbefore running pattern extraction.Written by Cursor Bugbot for commit 238949b. Configure here.