Skip to content

Update devcontainer configuration and Dockerfile for platform compatibility #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
answersamir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update devcontainer configuration and Dockerfile for platform compatibility #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
"name": "devtools",
"shutdownAction": "none",
"build": {
"dockerfile": "Dockerfile"
"dockerfile": "Dockerfile",
"args": {
"platform": "linux/amd64"
}
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform argument in devcontainer.json is redundant since the platform is already specified in the Dockerfile's FROM instruction. Docker build args for platform are typically not needed when --platform is used in FROM.

Suggested change
}
}

Copilot uses AI. Check for mistakes.
},
"updateRemoteUserUID": false,
"overrideCommand": false,
Expand Down
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,7 @@ build
**vm_uptime_stdout**
**vm_patch_stdout**
**vm_mem_stdout**
**vm_disk_stdout**
**vm_disk_stdout**

# devpod files
.devpod*
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM us-docker.pkg.dev/runwhen-nonprod-shared/public-images/codecollection-devtools:latest
FROM --platform=linux/amd64 us-docker.pkg.dev/runwhen-nonprod-shared/public-images/codecollection-devtools:latest
USER root

ENV RUNWHEN_HOME=/home/runwhen
Expand Down