Skip to content

fix: pin boto3<1.40 to keep non-AWS S3 uploads working #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimPietruskyRunPod wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pin boto3<1.40 to keep non-AWS S3 uploads working #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/pin-boto3-for-non-aws-s3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"worker-comfyui": patch
---

fix: pin `boto3<1.40` so S3 uploads to non-AWS providers (Cloudflare R2, Google Cloud Storage) keep working

boto3 1.40 ships a botocore release that enforces stricter AWS-only auth flows; uploads to S3-compatible endpoints like GCS and R2 began failing with `SignatureDoesNotMatch`. The fix is a version pin until upstream `runpod` and `aioboto3` stabilize on the new botocore. Reporter on #156 isolated this exactly: `boto3==1.35.40` works, `1.40.1` breaks.
7 changes: 5 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,11 @@ ADD src/extra_model_paths.yaml ./
# Go back to the root
WORKDIR /

# Install Python runtime dependencies for the handler
RUN uv pip install runpod requests websocket-client
# Install Python runtime dependencies for the handler.
# Pin boto3 < 1.40 to keep S3 uploads working against non-AWS S3 endpoints
# (Cloudflare R2, Google Cloud Storage). boto3 1.40+ ships a botocore that
# enforces stricter AWS-only auth flows; see issue #156.
RUN uv pip install runpod requests websocket-client 'boto3<1.40'

# Add application code and scripts
ADD src/start.sh src/network_volume.py handler.py test_input.json ./
Expand Down
Loading