fix: treat property names as case-insensitive#1
Merged
Conversation
Property names in ICS are case-insensitive per RFC 5545 §3.1.
Contributor
Author
|
@runely Did you noticed this PR? 🙂 |
Owner
|
Sorry, haven't noticed this. This seems like a reasonable fix 👍 |
Owner
|
@KristjanESPERANTO v1.0.1 has been released with this fix included |
Contributor
Author
|
@runely I'm guessing you're not even watching this repo, which is why you don't notice when someone opens an issue or a PR. Thanks for the merge! 😃 I see another issue - RDATE isn't supported. I'll probably experiment with that a bit over the next few days and maybe open a PR. Or should I open an issue first and wait for your input? |
Owner
|
As of now I'm using this as a pre filter to limit the ics content sent into the ics parser. But if it's needed to do initial filtering, then please open a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code only matches uppercase property names. But according to RFC 5545 §3.1, property names are case-insensitive, so feeds using
dtstart:orRrule:should be handled the same way as uppercaseDTSTART:orRRULE:.This PR fixes that by normalizing property-name checks before comparing them.
Context: We are evaluating
ics-filteras a dependency for MagicMirror#4168 instead of rolling our own ICS pre-filter. The general approach looks like a great fit for what we need, and I'd rather help improve a shared solution than maintain our own implementation.