Update Custom Emoji #10176
Open
Update Custom Emoji #10176
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove thread interrupt
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Member
|
this is what I meant by don't block - awaitTermination would block here |
riktenx
added
the
waiting for author
Member
|
you have to just shutdownNow() basically |
Apply PR feedback
runelite-github-app
bot
removed
the
waiting for author
Contributor
Author
|
Fixed =) |
Contributor
Author
|
Hey, fixed a bug and figured it'd be best if it was included in this PR. Here's the diff in case you already got most of the review done and want to see the specific changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, habitually did a
git reset --hard upstream/masterand thanos'd my other PR #10154This one has the feedback from @riktenx applied.