Update Runner configuration with installation and replica types#1806
Open
brmdias wants to merge 1 commit into
Open
Update Runner configuration with installation and replica types#1806brmdias wants to merge 1 commit into
brmdias wants to merge 1 commit into
Conversation
Added installationType and replicaType fields to the Runner configuration. Otherwise, the Runner is created in manual mode and the Pod will fail to start up...
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Kubernetes plugins overview documentation to ensure Runner creation via API includes the required runner configuration fields for Kubernetes installs, and fixes a formatting issue in the manual authentication section.
Changes:
- Added
installationType: kubernetesandreplicaType: ephemeralto the Runner creation API example. - Fixed an extra indentation issue so the “This node can now be targeted…” line renders as normal text.
| "installationType": "kubernetes", | ||
| "replicaType": "ephemeral" | ||
| }' | ||
| ``` |
Comment on lines
+60
to
+62
| "tagNames": ["K8S-RUNNER", "us-west-1", "cluster-1"], | ||
| "installationType": "kubernetes", | ||
| "replicaType": "ephemeral" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added installationType and replicaType fields to the Runner configuration. Otherwise, the Runner is created in manual mode and the Pod will fail to start up...