feat: stream project failure text to job page

[eamonryan]

When a plan or apply fails before producing any terraform output (e.g. lock contention, depends_on, requirement checks), the Atlantis job page linked from the GitHub commit status is blank because nothing is streamed to the output buffer before OperationComplete.

This is (normally) fine because the error is posted as a GitHub comment, but if you are someone who likes/needs to use silence_pr_comments because you have a lot of environments managed by Atlantis, then it's an issue because silence_pr_comments hides these errors.

This PR aims to fix that!

Solution: Emit a labeled Error:/Failure: banner to the job output stream from ProjectOutputWrapper.updateProjectPRStatus on the failure branch so the job page ends with a visible final status.

what

• Errors from lock contention, depends_on and requirement checks (e.g. approvals) will be logged in the streamed xterm output as well as in PR comments.

why

• If a user has silence_pr_comments enabled, they miss these errors, so this fixes that
• This should be harmless for users who do not use silence_pr_comments since it simply means the error will be in both a comment and in the streamed output
• We emit a labeled Error:/Failure: banner to the job output stream from ProjectOutputWrapper.updateProjectPRStatus on the failure branch so the job page ends with a visible final status.

tests

• Added tests to project_command_runner_test.go
• Built image locally and tested in my own environment
• Example of streamed error in xterm due to no-approval:

- Example of streamed error in xterm due to lock contention:

references

Refs: This was noted last year by a commenter here and obviously, also affects me or I wouldn't be submitting this ;)

[Copilot]

Pull request overview

This PR ensures that when a project plan/apply fails before any Terraform output is streamed, the per-project Atlantis job page is no longer blank by streaming a clear error/failure banner into the job output prior to the operation-complete signal.

Changes:

• Stream Error: and/or Failure: banners to the job output stream when a project command returns an error or failure.
• Add/extend unit tests to assert the ordering and content of streamed job messages (banners before OperationComplete).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
server/events/project_command_runner.go	Streams failure/error text into the job output stream on the failure branch of project status updates.
server/events/project_command_runner_test.go	Adds test cases and assertions verifying banners are streamed (and ordered) correctly before completion.

[lukemassa]

Nice, looks good to me!

[eamonryan]

@lukemassa thanks! i don't have permission to run the workflows but hopefully someone can :)

[chenrui333]

Thanks @eamonryan for your first contribution!